feat: (REST) Generate ApiVersion overrides on a per method basis

The change to the Translate Discovery doc is manual; there are no public Discovery docs that include API versions yet.
googleapis · Apr 17, 2024 · 184bfe2 · 184bfe2
1 parent 503c1e5
commit 184bfe2
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/....Generator.Rest.Tests/GoldenTestData/Google.Apis.Translate.v2/Google.Apis.Translate.v2.cs b/....Generator.Rest.Tests/GoldenTestData/Google.Apis.Translate.v2/Google.Apis.Translate.v2.cs
@@ -345,6 +345,9 @@ protected override void InitParameters()
             {
                 base.InitParameters();
             }
+
+            /// <inheritdoc/>
+            public override string ApiVersion => "testversion";
         }
 
         /// <summary>Detects the language of text within a request.</summary>

diff --git a/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Translate.v2/discovery.json b/Google.Api.Generator.Rest.Tests/GoldenTestData/Google.Apis.Translate.v2/discovery.json
@@ -123,6 +123,7 @@
   "detections": {
    "methods": {
     "detect": {
+     "apiVersion": "testversion",
      "description": "Detects the language of text within a request.",
      "httpMethod": "POST",
      "id": "language.detections.detect",

diff --git a/Google.Api.Generator.Rest/Models/MethodModel.cs b/Google.Api.Generator.Rest/Models/MethodModel.cs
@@ -53,6 +53,8 @@ public class MethodModel
         private bool SupportsMediaDownload => _restMethod.SupportsMediaDownload ?? false;
         private bool SupportsMediaUpload => _restMethod.SupportsMediaUpload ?? false;
 
+        public string ApiVersion => _restMethod.ApiVersion;
+
         public MethodModel(PackageModel package, ResourceModel resource, string name, RestMethod restMethod)
         {
             Package = GaxPreconditions.CheckNotNull(package, nameof(package));
@@ -194,13 +196,19 @@ private ClassDeclarationSyntax GenerateRequestType(SourceFileContext ctx)
                         parameters.Select(p => p.GenerateInitializer(ctx)).ToArray())
                     .WithXmlDoc(XmlDoc.Summary($"Initializes {PascalCasedName} parameter list."));
 
-                // TODO: Media downloader members
-
                 cls = cls.AddMembers(ctor);
                 cls = cls.AddMembers(parameters.SelectMany(p => p.GenerateDeclarations(ctx)).ToArray());
                 cls = cls.AddMembers(bodyDeclarations);
                 cls = cls.AddMembers(methodName, httpMethod, restPath, initParameters);
 
+                if (ApiVersion is string apiVersion)
+                {
+                    var apiVersionProperty = Property(Modifier.Public | Modifier.Override, ctx.Type<string>(), "ApiVersion")
+                        .WithGetBody(ApiVersion)
+                        .WithXmlDoc(XmlDoc.InheritDoc);
+                    cls = cls.AddMembers(apiVersionProperty);
+                }
+
                 if (SupportsMediaDownload)
                 {
                     cls = cls.AddMembers(mediaDownloaderProperty);