Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor codebase to protobuf-go v2 #1489

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Apr 10, 2024

A number of things are done to the project, all in the name of moving away from the deprecated protobuf-go v1 module.

  • We've replaced every usage of the protobuf-go v1 with the v2 drop-in equivalent
    • This includes both code generators, gapic and cli, as well as supporting libraries
  • Regenerated the grpc service config Go proto with the protobuf-go v2 code generator
  • Update all BUILD.bazel files with appropriate Go dependency changes
  • Remove protobuf-go v1 from go.mod/go.sum
  • Updated repositories.bzl based on go.mod/go.sum changes
  • Switch showcase.bash to use the individual protobuf-go v2 and grpc code gen plugins
  • Switch/add installs for protobuf-go v2 and grpc code gen plugins in CI workflow

* refactor gencli protov2
* remove last remnants
* update test script and ci
* update bazel deps to proto go v2
* remove unnecessary wkt resolution directives
@noahdietz noahdietz marked this pull request as ready for review April 10, 2024 18:00
@noahdietz noahdietz requested review from a team as code owners April 10, 2024 18:00
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@noahdietz noahdietz merged commit e84b5ef into googleapis:main Apr 11, 2024
7 checks passed
@noahdietz noahdietz deleted the proto-migration branch April 11, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants