Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gengapic): add x-goog-api-version header #1498

Merged
merged 4 commits into from
Apr 29, 2024
Merged

feat(gengapic): add x-goog-api-version header #1498

merged 4 commits into from
Apr 29, 2024

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Apr 26, 2024 •
edited
Loading

@quartzmo quartzmo marked this pull request as ready for review April 29, 2024 16:27
@quartzmo quartzmo requested review from a team as code owners April 29, 2024 16:27
noahdietz
noahdietz approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff!

@quartzmo quartzmo merged commit 9e22b2c into googleapis:main Apr 29, 2024
7 checks passed
@quartzmo quartzmo deleted the gengapic-api-version branch April 29, 2024 21:42
@release-please release-please bot mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quartzmo @noahdietz