Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unknown resources do not cause a generator crash #675

Merged
merged 2 commits into from
Oct 20, 2020
Merged

fix: unknown resources do not cause a generator crash #675

merged 2 commits into from
Oct 20, 2020

Commits on Oct 20, 2020

  1. fix: unknown resources do not cause a generator crash 

    Some resource references do not map to actual known resource types,
e.g. from the Logging API
string destination = 3 [
    (google.api.resource_reference) = {
        type: "*"
    }
];

It's easiest to just ignore invalid resource types.
    @software-dov
    software-dov committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    9140186 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into resource-for-real

    @busunkim96
    busunkim96 authored Oct 20, 2020
    Configuration menu
    Copy the full SHA
    1c752da View commit details
    Browse the repository at this point in the history