Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove auth, policy, and options from the reserved names list #851

Merged
merged 10 commits into from
Apr 30, 2021

Conversation

busunkim96
Copy link
Contributor

Fixes #835.

Breakdown by name that was originally added in #824

  • auth: from google import auth -> import google.auth
  • credentials: from google.auth import credentials -> from google.auth import credentials as ga_credentials
  • exceptions: from google.api_core import exceptions -> from google.api_core import exceptions as core_exceptions
  • future: skipped, as it is only used in the generated tests and has a low chance of colliding
  • options from google.iam.v1 import options_pb2 as options -> from google.iam.v1 import options_pb2
  • policy from google.iam.v1 import policy_pb2 as policy -> from google.iam.v1 import policy_pb2
  • math skipped as it is only used in generated tests

For options and policy there is a small change to gapic/schema/metadata.py to not alias _pb2 types

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 28, 2021
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #851 (0443936) into master (7c185e8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #851   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        27    +1     
  Lines         1608      1655   +47     
  Branches       328       338   +10     
=========================================
+ Hits          1608      1655   +47     
Impacted Files Coverage Δ
gapic/utils/case.py 100.00% <ø> (ø)
gapic/utils/reserved_names.py 100.00% <ø> (ø)
gapic/generator/generator.py 100.00% <100.00%> (ø)
gapic/schema/api.py 100.00% <100.00%> (ø)
gapic/schema/metadata.py 100.00% <100.00%> (ø)
gapic/schema/wrappers.py 100.00% <100.00%> (ø)
gapic/utils/__init__.py 100.00% <100.00%> (ø)
gapic/utils/checks.py 100.00% <100.00%> (ø)
gapic/utils/options.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b77107...0443936. Read the comment docs.

@busunkim96 busunkim96 marked this pull request as ready for review April 28, 2021 23:10
@busunkim96 busunkim96 requested a review from a team as a code owner April 28, 2021 23:10
@busunkim96 busunkim96 merged commit d3f31a0 into master Apr 30, 2021
@busunkim96 busunkim96 deleted the fix-policy-options branch April 30, 2021 20:12
gcf-merge-on-green bot pushed a commit that referenced this pull request May 20, 2021
Fixes #897 

The string ident changed to have an `_pb2` in #851. If there's a more robust way to do this comparison please let me know.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of policy and options to reserved names in #824 results in breaking changes to stable libraries
2 participants