-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove auth, policy, and options from the reserved names list #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 04bd8aa.
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Apr 28, 2021
Codecov Report
@@ Coverage Diff @@
## master #851 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 27 +1
Lines 1608 1655 +47
Branches 328 338 +10
=========================================
+ Hits 1608 1655 +47
Continue to review full report at Codecov.
|
software-dov
approved these changes
Apr 29, 2021
This was referenced May 19, 2021
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #835.
Breakdown by name that was originally added in #824
auth
:from google import auth
->import google.auth
credentials
:from google.auth import credentials
->from google.auth import credentials as ga_credentials
exceptions
:from google.api_core import exceptions
->from google.api_core import exceptions as core_exceptions
future
: skipped, as it is only used in the generated tests and has a low chance of collidingoptions
from google.iam.v1 import options_pb2 as options
->from google.iam.v1 import options_pb2
policy
from google.iam.v1 import policy_pb2 as policy
->from google.iam.v1 import policy_pb2
math
skipped as it is only used in generated testsFor
options
andpolicy
there is a small change togapic/schema/metadata.py
to not alias_pb2
types