Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tech debt: sort out Fallback and DEGAPIC client headers #873

Open
summer-ji-eng opened this issue May 14, 2021 · 0 comments
Open

tech debt: sort out Fallback and DEGAPIC client headers #873

summer-ji-eng opened this issue May 14, 2021 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@summer-ji-eng
Copy link
Collaborator

Currently, header x-goog-api-client has many values that some of them might not need, like grpc-web.

There is a technical implementation detail that Fallback and REGAPIC are implemented in the same file(src/fallback.ts). We should remove unused header and sort out the existing headers.
@summer-ji-eng summer-ji-eng added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@summer-ji-eng