This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Revert "fix: don't change PHP functions which are reserved words " #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 3ff8ca9.
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #3322 +/- ##
=========================================
Coverage 87.13% 87.13%
Complexity 6120 6120
=========================================
Files 495 495
Lines 24173 24173
Branches 2638 2638
=========================================
Hits 21064 21064
Misses 2242 2242
Partials 867 867
Continue to review full report at Codecov.
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3317
This PR requires a minimum version of PHP 7.0 in
google/cloud-compute. We will require this for thebeta, but for thealphawe can use the function nameslist_().