Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RestServiceCollection.GetRestMethod uses incorrect name #650

Closed
jskeet opened this issue Nov 29, 2022 · 0 comments · Fixed by #633 or #664
Closed

RestServiceCollection.GetRestMethod uses incorrect name #650

jskeet opened this issue Nov 29, 2022 · 0 comments · Fixed by #633 or #664
Assignees
@jskeet
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. release blocking Required feature/issue must be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@jskeet
Copy link
Collaborator

jskeet commented Nov 29, 2022

I've discovered this while investigating streaming behavior, but it's worrying that we didn't spot it before with tests.
Will make sure we have appropriate tests
@jskeet jskeet added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. release blocking Required feature/issue must be fixed prior to next release. labels Nov 29, 2022
@jskeet jskeet self-assigned this Nov 29, 2022
jskeet added a commit to jskeet/gax-dotnet that referenced this issue Nov 29, 2022
@jskeet
fix: Keep the gRPC full method name in RestServiceCollection
0151f16 
Fixes googleapis#650
jskeet added a commit to jskeet/gax-dotnet that referenced this issue Nov 29, 2022
@jskeet
fix: Keep the gRPC full method name in RestServiceCollection
f24381c 
Fixes googleapis#650
@jskeet jskeet closed this as completed in fcb1173 Nov 29, 2022
@release-please release-please bot mentioned this issue Nov 29, 2022
Merged
@jskeet jskeet mentioned this issue Dec 8, 2022
Merged
@release-please release-please bot mentioned this issue Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jskeet jskeet

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. release blocking Required feature/issue must be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
1 participant
@jskeet