Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Target netstandard2.0 in GAX #771

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

jskeet
Copy link
Collaborator

@jskeet jskeet commented Mar 20, 2024

This will allow us to target netstandard2.0 in client libraries as well. This is experimental at this stage - we're likely to release a beta with these targets, and then release a beta client library targeting netstandard2.0 with the GAX beta as a dependency, but a GA GAX release targeting netstandard2.0 is further out.

Note: the compatibility tester currently complains about various members, but I believe that's a bug in the tester - see dotnet/sdk#39629 for details. We should at least confirm that it's a bug before doing a GA release, but I think an alpha or beta would be okay before then.

This will allow us to target netstandard2.0 in client libraries as well.
This is experimental at this stage - we're likely to release a beta with these targets, and then release a beta client library targeting netstandard2.0 with the GAX beta as a dependency, but a GA GAX release targeting netstandard2.0 is further out.
@jskeet jskeet requested a review from a team as a code owner March 20, 2024 11:38
Copy link
Collaborator

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And yes, this should be OK for a beta.

One thing to try is a project using using a library targeting the stable GAX (netstandard2.1) and a library targetting the beta GAX (netstandard2.0) and see if there are any issues (there shouldn't be any I think).

Also, once we get the stable GAX released, we'd probably want to release all libraries in one go?

@jskeet jskeet merged commit cffd733 into googleapis:main Mar 20, 2024
4 checks passed
@jskeet jskeet deleted the test-netstandard20 branch March 20, 2024 16:26
@jskeet
Copy link
Collaborator Author

jskeet commented Mar 20, 2024

Yes, it would be good to try a combination of both, and shouldn't be hard to do.

As for releasing everything - maybe. It might be simplest to do a "release as normal for 3 months, and then do a catch-up set of releases for things which haven't been released in a while". We'll need to change the breaking change detector to look for netstandard2.0...

@jskeet
Copy link
Collaborator Author

jskeet commented Mar 20, 2024

Release-As: 4.8.0-alpha01

@jskeet jskeet added the release-please:force-run To run release-please label Mar 20, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Mar 20, 2024
@jskeet
Copy link
Collaborator Author

jskeet commented Mar 20, 2024

BEGIN_COMMIT_OVERRIDE
feat: Target netstandard2.0 in GAX

Release-As: 4.8.0-alpha01
END_COMMIT_OVERRIDE

@jskeet jskeet added the release-please:force-run To run release-please label Mar 20, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants