feat(v2): add OnHTTPCodes CallOption #188
Merged
+99
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codyoss
reviewed
May 5, 2022
codyoss
reviewed
May 5, 2022
| } | ||
|
|
||
| func (r *httpRetryer) Retry(err error) (time.Duration, bool) { | ||
| var gerr *googleapi.Error |
There was a problem hiding this comment.
Side note: Maybe we should do the work to wrap these with APIError so gax only opperates on this type directly...
There was a problem hiding this comment.
I'm not sure what you mean, can you elaborate? The main sticking point for me is that APIError doesn't have a Code property (we'd need to decide on a transport-agnostic Code type or align on gRPC Codes).
There was a problem hiding this comment.
Sorry, I mean in apiary-land we should consider starting to wrap those errors with APIError. I believe APIError has access to the raw googleapis.Error. Might make a PR to wrap things later...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
OnHTTPCodesCallOptionfor configuring aRetryerto retry a set of HTTP status codes present in anerrorof typegoogleapi.Error.