feat!: throw for versions of Node.js older than v10.0.0 #748

bcoe · 2020-03-20T00:20:44Z

This is waiting on landing: googleapis/google-cloud-node#2980

Note: we should test this in cloud functions once we get the first library using this version.

src/grpc.ts

alexander-fenster · 2020-03-20T00:26:39Z

We can merge it now, since all the 1.x versions are released from a branch https://github.com/googleapis/gax-nodejs/tree/1.15.x.

codecov · 2020-03-20T00:30:32Z

Codecov Report

Merging #748 into master will decrease coverage by 0.20%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
- Coverage   89.54%   89.33%   -0.21%     
==========================================
  Files          45       45              
  Lines        7344     7345       +1     
  Branches      468      452      -16     
==========================================
- Hits         6576     6562      -14     
- Misses        765      780      +15     
  Partials        3        3

Impacted Files	Coverage Δ
src/grpc.ts	`89.26% <40.00%> (-0.54%)`	⬇️
src/fallback.ts	`73.68% <0.00%> (-2.88%)`	⬇️
src/streamingCalls/streamingApiCaller.ts	`89.24% <0.00%> (-1.08%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1eccf9...570f2a8. Read the comment docs.

alexander-fenster · 2020-03-20T00:32:33Z

nit:

adding an extra space before https:// will make it perfect! :)

alexander-fenster · 2020-03-20T01:04:34Z

I think it's OK to merge it now, since the next release from master here will be a 2.0 release with no Node 8 support. Tadaaaa! 🎉

* chore: use gts v2 (#757) 247aeb7 commit 247aeb7 Author: Alexander Fenster <fenster@google.com> Date: Thu Mar 26 13:04:10 2020 -0700 chore: use gts v2 (#757) * chore: use gts v2 * chore: ahhhhh thaaaats why * chore: do not run on node8 * fix: new gts rules * build: use TypeScript ^3.8.3, set lib to es2018 (#760) 41c73f8 commit 41c73f8 Author: Alexander Fenster <fenster@google.com> Date: Thu Mar 26 13:34:19 2020 -0700 build: use TypeScript ^3.8.3, set lib to es2018 (#760) * build: use TypeScript ^3.8.3, set lib to es2018 * fix: better typing * chore!: require Node.js v10+ (#759) 23ec7f6 commit 23ec7f6 Author: Alexander Fenster <fenster@google.com> Date: Thu Mar 26 14:07:14 2020 -0700 chore!: require Node.js v10+ (#759) BREAKING CHANGE: use Node.js v10+ * chore(deps): update dependency @types/rimraf to v3 (#751) 2f1b6ae commit 2f1b6ae Author: WhiteSource Renovate <bot@renovateapp.com> Date: Thu Mar 26 22:27:20 2020 +0100 chore(deps): update dependency @types/rimraf to v3 (#751) Co-authored-by: Alexander Fenster <fenster@google.com> * chore: release 2.0.0 (#738) 1c11c80 commit 1c11c80 Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Date: Thu Mar 26 22:32:20 2020 +0000 chore: release 2.0.0 (#738) 🤖 I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://www.github.com/googleapis/gax-nodejs/compare/v1.14.2...v2.0.0) (2020-03-26) ### ⚠ BREAKING CHANGES * use Node.js v10+ * throw for versions of Node.js older than v10.0.0 (#748) * stop accepting Promise constructor (#737) ### Features * export bundle descriptor in descriptors interface ([#744](https://www.github.com/googleapis/gax-nodejs/issues/744)) ([b1eccf9](https://www.github.com/googleapis/gax-nodejs/commit/b1eccf96c439d67376d249a54c9d22ffe7ff1839)) * export ServiceError from @grpc/grpc-js ([#754](https://www.github.com/googleapis/gax-nodejs/issues/754)) ([24a4d60](https://www.github.com/googleapis/gax-nodejs/commit/24a4d600738a9597e9a87d6705eaed3dc2285e3b)) * stop accepting Promise constructor ([#737](https://www.github.com/googleapis/gax-nodejs/issues/737)) ([816bf9b](https://www.github.com/googleapis/gax-nodejs/commit/816bf9b283217208debd979e893a6daf29f1f739)) * support async iterator for paging method ([#708](https://www.github.com/googleapis/gax-nodejs/issues/708)) ([3ac5afb](https://www.github.com/googleapis/gax-nodejs/commit/3ac5afb3b1b1b22798f15ee07395f3ca765383b4)) * throw for versions of Node.js older than v10.0.0 ([#748](https://www.github.com/googleapis/gax-nodejs/issues/748)) ([511fc23](https://www.github.com/googleapis/gax-nodejs/commit/511fc233bd66d537c24743ef460ee8c609cd551f)) ### Bug Fixes * **deps:** update dependency @grpc/grpc-js to ^0.7.0 ([#736](https://www.github.com/googleapis/gax-nodejs/issues/736)) ([01c428c](https://www.github.com/googleapis/gax-nodejs/commit/01c428cb1240320b92778abf1297a5ff72346fd9)) * **deps:** use @grpc/grpc-js v0.7.2 ([#735](https://www.github.com/googleapis/gax-nodejs/issues/735)) ([836e81b](https://www.github.com/googleapis/gax-nodejs/commit/836e81b64f84d8c118e6aea0580f0645658a8490)) * **deps:** use protobuf.js v6.8.9 ([#743](https://www.github.com/googleapis/gax-nodejs/issues/743)) ([fab91ce](https://www.github.com/googleapis/gax-nodejs/commit/fab91ce334d76212d7e31b5478331339c5acad76)) * allow passing numbers as path template parameters ([#756](https://www.github.com/googleapis/gax-nodejs/issues/756)) ([c466d3d](https://www.github.com/googleapis/gax-nodejs/commit/c466d3dc68c8f9050d3ae69dcedd708e3509ae17)) ### Miscellaneous Chores * require Node.js v10+ ([#759](https://www.github.com/googleapis/gax-nodejs/issues/759)) ([23ec7f6](https://www.github.com/googleapis/gax-nodejs/commit/23ec7f69c3813f6d06ea8b2a473d072337e1b499)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * fix(deps): update dependency google-auth-library to v6 (#763) 72114db commit 72114db Author: WhiteSource Renovate <bot@renovateapp.com> Date: Sat Mar 28 04:08:38 2020 +0100 fix(deps): update dependency google-auth-library to v6 (#763) * fix: make async iteration work for gRPC-fallback; refactor the code (#765) 944c06b commit 944c06b Author: Alexander Fenster <fenster@google.com> Date: Fri Mar 27 22:19:15 2020 -0700 fix: make async iteration work for gRPC-fallback; refactor the code (#765) * chore: release 2.0.1 (#766) 3ce902d commit 3ce902d Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Date: Sat Mar 28 05:30:07 2020 +0000 chore: release 2.0.1 (#766) 🤖 I have created a release \*beep\* \*boop\* --- ### [2.0.1](https://www.github.com/googleapis/gax-nodejs/compare/v2.0.0...v2.0.1) (2020-03-28) ### Bug Fixes * **deps:** update dependency google-auth-library to v6 ([#763](https://www.github.com/googleapis/gax-nodejs/issues/763)) ([72114db](https://www.github.com/googleapis/gax-nodejs/commit/72114db1b15af3034c51a784e3fc619e2ee281e5)) * make async iteration work for gRPC-fallback; refactor the code ([#765](https://www.github.com/googleapis/gax-nodejs/issues/765)) ([944c06b](https://www.github.com/googleapis/gax-nodejs/commit/944c06b4225c4dd5cdcf08e4ca2497cfe3a69cde)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). * build: set AUTOSYNTH_MULTIPLE_COMMITS=true for context aware commits (#770) a1e4a3f commit a1e4a3f Author: Benjamin E. Coe <bencoe@google.com> Date: Tue Mar 31 18:34:30 2020 -0700 build: set AUTOSYNTH_MULTIPLE_COMMITS=true for context aware commits (#770) * fix: do not run node 8 CI (#456) googleapis/synthtool@1b4cc80 commit 1b4cc80a7aaf164f6241937dd87f3bd1f4149e0c Author: Alexander Fenster <fenster@google.com> Date: Wed Mar 25 08:01:31 2020 -0700 fix: do not run node 8 CI (#456) * fix: update template files for Node.js libraries (#463) googleapis/synthtool@9982024 commit 99820243d348191bc9c634f2b48ddf65096285ed Author: Alexander Fenster <fenster@google.com> Date: Tue Mar 31 11:56:27 2020 -0700 fix: update template files for Node.js libraries (#463)

feat!: throw for versions of Node.js older than v10.0.0

3a5ca2d

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 20, 2020

bcoe requested a review from alexander-fenster March 20, 2020 00:20

alexander-fenster reviewed Mar 20, 2020

View reviewed changes

src/grpc.ts Outdated Show resolved Hide resolved

chore: address code review

0f55c7f

alexander-fenster approved these changes Mar 20, 2020

View reviewed changes

bcoe and others added 2 commits March 19, 2020 17:33

chore: add a space

b14db1e

chore: remove node 8 from CI

570f2a8

alexander-fenster merged commit 511fc23 into master Mar 20, 2020

release-please bot mentioned this pull request Mar 20, 2020

chore: release 2.0.0 #738

Merged

This was referenced Jun 26, 2023

feat: upgraded to node v18, added .nvmrc and updated workflows openedx/edx-enterprise#1729

Merged

Specify supported Node/NPM versions in engines property within package.json openedx/wg-frontend#171

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: throw for versions of Node.js older than v10.0.0 #748

feat!: throw for versions of Node.js older than v10.0.0 #748

bcoe commented Mar 20, 2020 •

edited

Loading

alexander-fenster commented Mar 20, 2020

codecov bot commented Mar 20, 2020 •

edited

Loading

alexander-fenster commented Mar 20, 2020 •

edited

Loading

alexander-fenster commented Mar 20, 2020

feat!: throw for versions of Node.js older than v10.0.0 #748

feat!: throw for versions of Node.js older than v10.0.0 #748

Conversation

bcoe commented Mar 20, 2020 • edited Loading

alexander-fenster commented Mar 20, 2020

codecov bot commented Mar 20, 2020 • edited Loading

Codecov Report

alexander-fenster commented Mar 20, 2020 • edited Loading

alexander-fenster commented Mar 20, 2020

bcoe commented Mar 20, 2020 •

edited

Loading

codecov bot commented Mar 20, 2020 •

edited

Loading

alexander-fenster commented Mar 20, 2020 •

edited

Loading