Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: add status as a number to GaxiosError, change code to error code as a string #552

Merged
merged 4 commits into from
Jul 12, 2023
Merged

fix!: add status as a number to GaxiosError, change code to error code as a string #552

merged 4 commits into from
Jul 12, 2023

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Jul 11, 2023

@sofisl sofisl requested a review from a team as a code owner July 11, 2023 21:49
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jul 11, 2023
danielbankhead
danielbankhead reviewed Jul 11, 2023
View reviewed changes
src/common.ts Outdated Show resolved Hide resolved
danielbankhead
danielbankhead reviewed Jul 11, 2023
View reviewed changes
src/common.ts Outdated Show resolved Hide resolved
danielbankhead
danielbankhead reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few suggestions

src/common.ts Outdated Show resolved Hide resolved
src/common.ts Outdated Show resolved Hide resolved
src/common.ts Show resolved Hide resolved
src/common.ts Outdated Show resolved Hide resolved
danielbankhead
danielbankhead reviewed Jul 12, 2023
View reviewed changes
src/common.ts Outdated Show resolved Hide resolved
@sofisl sofisl changed the title fix!: change code to number, and response status to string fix!: add status as GaxiosError property, change code to error code as a number Jul 12, 2023
@sofisl sofisl changed the title fix!: add status as GaxiosError property, change code to error code as a number fix!: add status as a number to GaxiosError, change code to error code as a string Jul 12, 2023
@sofisl sofisl merged commit 88ba2e9 into main Jul 12, 2023
@sofisl sofisl deleted the changeCodeToStatus branch July 12, 2023 20:22
@release-please release-please bot mentioned this pull request Jul 12, 2023
Merged
@sofisl sofisl mentioned this pull request Jul 28, 2023
Merged
@danielbankhead danielbankhead mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

err.code type changes from 'string' to 'number'.
2 participants
@sofisl @danielbankhead