update from googleapis #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbza
commented
May 11, 2018
|
|
||
| // SubscriberClient is the client API for Subscriber service. | ||
| // | ||
| // For semantics around ctx use and closing/ending streaming RPCs, please refer to https://godoc.org/google.golang.org/grpc#ClientConn.NewStream. |
There was a problem hiding this comment.
This is the main change I was going for. (see my change to the grpc proto generator golang/protobuf@32a84b2)
There was a problem hiding this comment.
@jba small note - this (belated) CL will help in future cases where we/users are confused about closing streams.
(link - https://godoc.org/google.golang.org/grpc#ClientConn.NewStream)
|
This adds the XXX fields. Have we test-compile this against google-cloud-go? |
|
Good point. I've created https://code-review.googlesource.com/c/gocloud/+/27691. We should wait until that is done to merge this. |
|
@pongad I believe this is good to go. Any reason to delay that you can think of? |
|
@jadekler No I think we are good now. LGTM |
pongad
approved these changes
May 14, 2018
hsanjuan
pushed a commit
to gxed/go-genproto-googleapis-rpc
that referenced
this pull request
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.