feat: adds universe domain support for compute credentials #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimurSadykov
requested review from
blakeli0,
lqiu96,
westarle and
arithmetic1728
TimurSadykov
commented
Dec 28, 2023
| @@ -83,134 +85,152 @@ public void setIdToken(String idToken) { | |||
| @Override | |||
| public LowLevelHttpRequest buildRequest(String method, String url) throws IOException { | |||
| if (url.equals(ComputeEngineCredentials.getTokenServerEncodedUrl())) { | |||
| return getMockRequestForTokenEndpoint(url); | |||
There was a problem hiding this comment.
This diff might be tricky to read. What I did is I factored out all the if-statements contents in a separate private methods. Some are big statements that made this method hard to read.
TimurSadykov
commented
Dec 28, 2023
westarle
reviewed
Dec 28, 2023
oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java
Outdated
Show resolved
Hide resolved
lqiu96
reviewed
Dec 29, 2023
lqiu96
reviewed
Dec 29, 2023
lqiu96
approved these changes
Jan 2, 2024
arithmetic1728
approved these changes
Jan 2, 2024
lsirac
approved these changes
Jan 4, 2024
westarle
approved these changes
Jan 5, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds universe domain support to GCE credentials.
In case explicit universe_domain was provided - it takes priority
Otherwise - GCE credential tries to obtain a universe domain from Metadata service
If request fails with 404 or request returns an empty string - universe domain is set to GDU
If any other error - throws a retryable exception