Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "fix: Issue #1347: ExternalAccountCredentials serialization is broken"" #1365

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Revert "Revert "fix: Issue #1347: ExternalAccountCredentials serialization is broken"" #1365

merged 2 commits into from
Feb 8, 2024

Conversation

BigTailWolf
Copy link
Contributor

Reverts #1359

@BigTailWolf BigTailWolf requested review from a team as code owners February 6, 2024 23:37
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 6, 2024
@BigTailWolf BigTailWolf added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 6, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

TimurSadykov
TimurSadykov approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BigTailWolf BigTailWolf removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 8, 2024
@BigTailWolf BigTailWolf merged commit b1096fe into main Feb 8, 2024
21 checks passed
@BigTailWolf BigTailWolf deleted the revert-1359-revert-1358-b317995693 branch February 8, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimurSadykov TimurSadykov TimurSadykov approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BigTailWolf @TimurSadykov