Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add example and readme for using fromJSON #220

Merged
merged 2 commits into from
Dec 27, 2017
Merged

docs: add example and readme for using fromJSON #220

merged 2 commits into from
Dec 27, 2017

Conversation

JustinBeckwith
Copy link
Contributor

Addresses #152

@JustinBeckwith JustinBeckwith requested review from ofrobots and a team December 26, 2017 06:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 26, 2017
ofrobots
ofrobots reviewed Dec 26, 2017
View reviewed changes
README.md Outdated
const url = `https://www.googleapis.com/dns/v1/projects/${keys.project_id}`;
const res = await client.request({url});
console.log(res.data);
} catch(e) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

README.md Outdated
} catch(e) {
console.error(e);
}
process.exit();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@JustinBeckwith JustinBeckwith merged commit 525a74f into googleapis:next Dec 27, 2017
@JustinBeckwith JustinBeckwith mentioned this pull request Dec 28, 2017
Closed
ofrobots pushed a commit that referenced this pull request Jan 9, 2018
@JustinBeckwith @ofrobots
docs: add example and readme for using fromJSON (#220)
26f6161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustinBeckwith @ofrobots @googlebot