Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add JWT.getCredentials method #323

Merged
merged 3 commits into from
Mar 14, 2018
Merged

feat: add JWT.getCredentials method #323

merged 3 commits into from
Mar 14, 2018

Conversation

JustinBeckwith
Copy link
Contributor

Resolves #313

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 13, 2018
@codecov-io
Copy link

codecov-io commented Mar 13, 2018 •
edited
Loading

Codecov Report

Merging #323 into master will decrease coverage by 0.15%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   94.66%   94.51%   -0.16%     
==========================================
  Files          14       14              
  Lines         900      911      +11     
  Branches      187      187              
==========================================
+ Hits          852      861       +9     
- Misses         48       50       +2
Impacted Files Coverage Δ
src/auth/googleauth.ts 94.42% <ø> (ø) ⬆️
src/auth/jwtclient.ts 93.93% <85.71%> (-1.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5a1e7...cef758b. Read the comment docs.

jinwoo
jinwoo reviewed Mar 14, 2018
View reviewed changes
src/auth/jwtclient.ts Outdated
@@ -168,6 +168,20 @@ export class JWT extends OAuth2Client {
* @private
*/
async refreshToken(refreshToken?: string|null): Promise<GetTokenResponse> {
this.createGToken();
const token = await this.gtoken!.getToken();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

src/auth/jwtclient.ts Outdated
* Using the key or keyFile on the JWT client, obtain an object that contains
* the key and the client email.
*/
async getCredentials() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@JustinBeckwith JustinBeckwith merged commit df75b73 into googleapis:master Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinwoo jinwoo jinwoo approved these changes

@ofrobots ofrobots Awaiting requested review from ofrobots

@alexander-fenster alexander-fenster Awaiting requested review from alexander-fenster

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JustinBeckwith @codecov-io @jinwoo @googlebot