Raise HTTP error if encountered #1167
Open
+39
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtemple
requested review from
arithmetic1728,
sai-sunder-s and
a team
as code owners
clundin25
reviewed
Oct 25, 2022
| @@ -433,6 +433,7 @@ def refresh(self, request): | |||
| headers=headers, | |||
| data=json.dumps(body).encode("utf-8"), | |||
| ) | |||
| response.raise_for_status() | |||
There was a problem hiding this comment.
Could you write a test for this?
There was a problem hiding this comment.
@clundin25, I've attempted to write a test. Let me know if you'd like me to approach it differently.
There was a problem hiding this comment.
refresh method normally throws RefreshError (https://github.com/googleapis/google-auth-library-python/blob/main/google/auth/exceptions.py#L35), could you maybe check the status code and raise a RefreshError instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the user is not authorized to make a request, there is no token in the response so the user receives a KeyError, which is less informative than the HTTPError returned from the API.
Raising the HTTP error solves this.