Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: better guidance for authentication samples #10184

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Nov 7, 2022

The samples to override the authentication defaults were chosen for simplicity, not to represent the best practices for authentication. This changes the Doxygen landing pages for storage and pubsub to provide better guidance and links to best practices.


This change is Reviewable

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 7, 2022
The samples to override the authentication defaults were chosen for
simplicity, not to represent the best practices for authentication.
This changes the Doxygen landing pages for `storage` and `pubsub` to
provide better guidance and links to best practices.
@coryan coryan force-pushed the doc-improve-hand-crafted-landing-pages branch from fd7f35f to 3e2abb9 Compare November 7, 2022 16:17
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 3e2abb9b7a47309031cb4ad3a79c580a58a0e04d

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 93.97% // Head: 93.97% // No change to project coverage 👍

Coverage data is based on head (4a5b812) compared to base (4a5b812).
Patch has no changes to coverable lines.

❗ Current head 4a5b812 differs from pull request most recent head 3e2abb9. Consider uploading reports for the commit 3e2abb9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10184   +/-   ##
=======================================
  Coverage   93.97%   93.97%           
=======================================
  Files        1526     1526           
  Lines      140600   140600           
=======================================
  Hits       132129   132129           
  Misses       8471     8471           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review November 7, 2022 17:04
@coryan coryan requested a review from a team as a code owner November 7, 2022 17:04
@coryan coryan merged commit 5727b80 into googleapis:main Nov 7, 2022
@coryan coryan deleted the doc-improve-hand-crafted-landing-pages branch November 7, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants