Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(common): add overview section #10193

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Nov 7, 2022

This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f01421bc62ef681d3207d8cdb23084cb0bb3226a

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 93.97% // Head: 93.97% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f01421b) compared to base (71b11b6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10193      +/-   ##
==========================================
- Coverage   93.97%   93.97%   -0.01%     
==========================================
  Files        1526     1526              
  Lines      140600   140600              
==========================================
- Hits       132130   132125       -5     
- Misses       8470     8475       +5     
Impacted Files Coverage Δ
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.15% <0.00%> (-0.51%) ⬇️
google/cloud/pubsub/samples/samples.cc 90.70% <0.00%> (-0.08%) ⬇️
...sub/internal/batching_publisher_connection_test.cc 99.62% <0.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review November 7, 2022 22:55
@coryan coryan requested a review from a team as a code owner November 7, 2022 22:55
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan enabled auto-merge (squash) November 7, 2022 23:07
@coryan coryan merged commit d02462b into googleapis:main Nov 7, 2022
@coryan coryan deleted the doc-common-separate-overview-section-for-guac branch November 7, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants