fix(common): create default gRPC credentials only if needed #10280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For backwards compatibility with the pre-Unified Credentials world we were calling `grpc::GoogleDefaultCredentials()` if `g::c::GrpcCredentialsOption` was not set. In many cases the option is not set, but `g::c::UnifiedCredentialsOption` is. If that is the case, the unified options are preferred. Calling `grpc::GoogleDefaultCredentials()` produces spurious errors, and these credentials won't be used.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.83% // Head: 93.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10280 +/- ##
=======================================
Coverage 93.83% 93.83%
=======================================
Files 1573 1573
Lines 144070 144071 +1
=======================================
+ Hits 135182 135188 +6
+ Misses 8888 8883 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For backwards compatibility with the pre-Unified Credentials world we were calling
grpc::GoogleDefaultCredentials()ifg::c::GrpcCredentialsOptionwas not set. In many cases the option is not set, butg::c::UnifiedCredentialsOptionis. If that is the case, the unified options are preferred. Callinggrpc::GoogleDefaultCredentials()produces spurious errors, and these credentials won't be used.This change is