Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): use FQDN for the metadata service #13139

Merged

Conversation

coryan
Copy link
Member

@coryan coryan commented Nov 15, 2023

This change is Reviewable

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de2296b) 92.99% compared to head (211554a) 92.99%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13139      +/-   ##
==========================================
- Coverage   92.99%   92.99%   -0.01%     
==========================================
  Files        2135     2135              
  Lines      185662   185662              
==========================================
- Hits       172654   172651       -3     
- Misses      13008    13011       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review November 15, 2023 19:39
@coryan coryan requested a review from a team as a code owner November 15, 2023 19:39
@coryan coryan merged commit a6cdcdb into googleapis:main Nov 15, 2023
59 checks passed
@coryan coryan deleted the fix-common-use-fqdn-for-metadata-service branch November 15, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants