Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): split WellKnownParameter #13637

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 20, 2024

Part of the work for #13575


This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (452ccdf) 93.27% compared to head (85425a4) 93.27%.
Report is 3 commits behind head on main.

Files Patch % Lines
...loud/storage/internal/well_known_parameters_impl.h 88.88% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13637   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files        2227     2228    +1     
  Lines      193714   193714           
=======================================
+ Hits       180684   180688    +4     
+ Misses      13030    13026    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review February 20, 2024 22:39
@coryan coryan requested a review from a team as a code owner February 20, 2024 22:39
@coryan coryan merged commit c1b0e79 into googleapis:main Feb 21, 2024
62 checks passed
@coryan coryan deleted the refactor-storage-well-known-parameters-impl branch February 21, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants