Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl(GCS+gRPC): export metrics with desired monitored resource #14270

Merged
merged 3 commits into from
Jul 25, 2024
Merged

impl(GCS+gRPC): export metrics with desired monitored resource #14270

merged 3 commits into from
Jul 25, 2024

Conversation

coryan
Copy link
Contributor

@coryan coryan commented May 21, 2024 •
edited
Loading

Fixes #13998

This change is Reviewable

@codecov Codecov
Copy link

codecov bot commented May 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (ee21b70) to head (d5d80b5).
Report is 92 commits behind head on main.

Files with missing lines Patch % Lines
.../storage/internal/grpc/metrics_exporter_options.cc 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #14270   +/-   ##
=======================================
  Coverage   93.58%   93.59%           
=======================================
  Files        2318     2318           
  Lines      207177   207163   -14     
=======================================
+ Hits       193886   193893    +7     
+ Misses      13291    13270   -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan force-pushed the impl-GCS+gRPC-always-enable-gRPC-metrics-pr7 branch from c16d4d8 to a55d4d0 Compare May 22, 2024 14:52
@coryan coryan force-pushed the impl-GCS+gRPC-always-enable-gRPC-metrics-pr7 branch from a55d4d0 to 64a1d1b Compare May 23, 2024 13:04
@coryan coryan force-pushed the impl-GCS+gRPC-always-enable-gRPC-metrics-pr7 branch from 64a1d1b to 464cc76 Compare June 25, 2024 12:35
@coryan coryan force-pushed the impl-GCS+gRPC-always-enable-gRPC-metrics-pr7 branch from 464cc76 to ca3e8ef Compare June 27, 2024 18:11
@coryan coryan force-pushed the impl-GCS+gRPC-always-enable-gRPC-metrics-pr7 branch from ca3e8ef to 7e4224d Compare June 27, 2024 19:32
@coryan coryan force-pushed the impl-GCS+gRPC-always-enable-gRPC-metrics-pr7 branch from 7e4224d to a1e9b19 Compare July 12, 2024 13:15
@coryan coryan force-pushed the impl-GCS+gRPC-always-enable-gRPC-metrics-pr7 branch from a1e9b19 to d5d80b5 Compare July 25, 2024 20:28
@coryan coryan marked this pull request as ready for review July 25, 2024 20:55
@coryan coryan requested review from a team as code owners July 25, 2024 20:55
scotthart
scotthart approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan merged commit 404272c into googleapis:main Jul 25, 2024
67 checks passed
@coryan coryan deleted the impl-GCS+gRPC-always-enable-gRPC-metrics-pr7 branch July 25, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotthart scotthart scotthart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create helpers to initialize and export gRPC metrics
2 participants
@coryan @scotthart