feat(storage): disable XML via environment variable #5100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using emulators that do not support XML, application developers may need to switch off the automatic XML switching in the client library. We use an environment variable over a `ClientOptions` setting because (a) this is an implementation detail that we want to change if needed, a setting would require API changes, and (b) this appears to be needed only for development / testing, presumably the application developers don't want to change their code to test against an emulator vs. production.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #5100 +/- ##
==========================================
- Coverage 95.82% 95.82% -0.01%
==========================================
Files 986 986
Lines 90350 90355 +5
==========================================
+ Hits 86580 86582 +2
- Misses 3770 3773 +3
Continue to review full report at Codecov.
|
devbww
approved these changes
Sep 19, 2020
coryan
deleted the
feat-storage-disable-xml-via-environment-variable
branch
|
Nice, thank you for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using emulators that do not support XML, application developers may
need to switch off the automatic XML switching in the client library. We
use an environment variable over a
ClientOptionssetting because (a)this is an implementation detail that we want to change if needed, a
setting would require API changes, and (b) this appears to be needed
only for development / testing, presumably the application developers
don't want to change their code to test against an emulator vs.
production.
Fixes #5072
This change is