fix!: Mark a couple networkconnectivity API fields as required, to ma…

…tch implemented behavior PiperOrigin-RevId: 408969147 Source-Link: googleapis/googleapis@cc003a4 Source-Link: googleapis/googleapis-gen@72d5b22 Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuTmV0d29ya0Nvbm5lY3Rpdml0eS5WMS8uT3dsQm90LnlhbWwiLCJoIjoiNzJkNWIyMmUyMTI0YzdhNWY2Y2QzMTg2NGY3ZjhjOTNhNWRmMzU5MiJ9
googleapis · Nov 11, 2021 · 10e499d · 10e499d
1 parent 6489853
commit 10e499d
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 29 deletions.
diff --git a/apis/Google.Cloud.NetworkConnectivity.V1/Google.Cloud.NetworkConnectivity.V1/Hub.g.cs b/apis/Google.Cloud.NetworkConnectivity.V1/Google.Cloud.NetworkConnectivity.V1/Hub.g.cs
@@ -72,7 +72,7 @@ static HubReflection() {
             "ASABKAlCLuBBAvpBKAombmV0d29ya2Nvbm5lY3Rpdml0eS5nb29nbGVhcGlz",
             "LmNvbS9IdWIitwEKEENyZWF0ZUh1YlJlcXVlc3QSOQoGcGFyZW50GAEgASgJ",
             "QingQQL6QSMKIWxvY2F0aW9ucy5nb29nbGVhcGlzLmNvbS9Mb2NhdGlvbhIT",
-            "CgZodWJfaWQYAiABKAlCA+BBARI6CgNodWIYAyABKAsyKC5nb29nbGUuY2xv",
+            "CgZodWJfaWQYAiABKAlCA+BBAhI6CgNodWIYAyABKAsyKC5nb29nbGUuY2xv",
             "dWQubmV0d29ya2Nvbm5lY3Rpdml0eS52MS5IdWJCA+BBAhIXCgpyZXF1ZXN0",
             "X2lkGAQgASgJQgPgQQEinQEKEFVwZGF0ZUh1YlJlcXVlc3QSNAoLdXBkYXRl",
             "X21hc2sYASABKAsyGi5nb29nbGUucHJvdG9idWYuRmllbGRNYXNrQgPgQQES",
@@ -90,7 +90,7 @@ static HubReflection() {
             "BG5hbWUYASABKAlCMOBBAvpBKgoobmV0d29ya2Nvbm5lY3Rpdml0eS5nb29n",
             "bGVhcGlzLmNvbS9TcG9rZSK/AQoSQ3JlYXRlU3Bva2VSZXF1ZXN0EjkKBnBh",
             "cmVudBgBIAEoCUIp4EEC+kEjCiFsb2NhdGlvbnMuZ29vZ2xlYXBpcy5jb20v",
-            "TG9jYXRpb24SFQoIc3Bva2VfaWQYAiABKAlCA+BBARI+CgVzcG9rZRgDIAEo",
+            "TG9jYXRpb24SFQoIc3Bva2VfaWQYAiABKAlCA+BBAhI+CgVzcG9rZRgDIAEo",
             "CzIqLmdvb2dsZS5jbG91ZC5uZXR3b3JrY29ubmVjdGl2aXR5LnYxLlNwb2tl",
             "QgPgQQISFwoKcmVxdWVzdF9pZBgEIAEoCUID4EEBIqMBChJVcGRhdGVTcG9r",
             "ZVJlcXVlc3QSNAoLdXBkYXRlX21hc2sYASABKAsyGi5nb29nbGUucHJvdG9i",
@@ -228,8 +228,8 @@ public enum State {
 
   #region Messages
   /// <summary>
-  /// A hub is essentially a collection of spokes. A single hub can contain spokes
-  /// from multiple regions. However, all of a hub's spokes must be associated with
+  /// A hub is a collection of spokes. A single hub can contain spokes from
+  /// multiple regions. However, all of a hub's spokes must be associated with
   /// resources that reside in the same VPC network.
   /// </summary>
   public sealed partial class Hub : pb::IMessage<Hub>
@@ -712,7 +712,7 @@ public void MergeFrom(pb::CodedInputStream input) {
   }
 
   /// <summary>
-  /// RoutingsVPC contains information about a VPC network that is associated with
+  /// RoutingVPC contains information about the VPC network that is associated with
   /// a hub's spokes.
   /// </summary>
   public sealed partial class RoutingVPC : pb::IMessage<RoutingVPC>
@@ -763,7 +763,7 @@ public RoutingVPC Clone() {
     public const int UriFieldNumber = 1;
     private string uri_ = "";
     /// <summary>
-    /// The URI of a VPC network.
+    /// The URI of the VPC network.
     /// </summary>
     [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
     [global::System.CodeDom.Compiler.GeneratedCode("protoc", null)]
@@ -1054,7 +1054,7 @@ public string Description {
     public const int HubFieldNumber = 6;
     private string hub_ = "";
     /// <summary>
-    /// Immutable. The URI of the hub that this spoke is attached to.
+    /// Immutable. The name of the hub that this spoke is attached to.
     /// </summary>
     [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
     [global::System.CodeDom.Compiler.GeneratedCode("protoc", null)]
@@ -2423,7 +2423,7 @@ public string Parent {
     public const int HubIdFieldNumber = 2;
     private string hubId_ = "";
     /// <summary>
-    /// Optional. A unique identifier for the hub.
+    /// Required. A unique identifier for the hub.
     /// </summary>
     [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
     [global::System.CodeDom.Compiler.GeneratedCode("protoc", null)]
@@ -4122,7 +4122,7 @@ public string Parent {
     public const int SpokeIdFieldNumber = 2;
     private string spokeId_ = "";
     /// <summary>
-    /// Optional. Unique id for the spoke to create.
+    /// Required. Unique id for the spoke to create.
     /// </summary>
     [global::System.Diagnostics.DebuggerNonUserCodeAttribute]
     [global::System.CodeDom.Compiler.GeneratedCode("protoc", null)]

diff --git a/...le.Cloud.NetworkConnectivity.V1/Google.Cloud.NetworkConnectivity.V1/HubServiceClient.g.cs b/...le.Cloud.NetworkConnectivity.V1/Google.Cloud.NetworkConnectivity.V1/HubServiceClient.g.cs
@@ -764,15 +764,15 @@ public virtual Hub GetHub(HubName name, gaxgrpc::CallSettings callSettings = nul
         /// Required. The initial values for a new hub.
         /// </param>
         /// <param name="hubId">
-        /// Optional. A unique identifier for the hub.
+        /// Required. A unique identifier for the hub.
         /// </param>
         /// <param name="callSettings">If not null, applies overrides to this RPC call.</param>
         /// <returns>The RPC response.</returns>
         public virtual lro::Operation<Hub, OperationMetadata> CreateHub(string parent, Hub hub, string hubId, gaxgrpc::CallSettings callSettings = null) =>
             CreateHub(new CreateHubRequest
             {
                 Parent = gax::GaxPreconditions.CheckNotNullOrEmpty(parent, nameof(parent)),
-                HubId = hubId ?? "",
+                HubId = gax::GaxPreconditions.CheckNotNullOrEmpty(hubId, nameof(hubId)),
                 Hub = gax::GaxPreconditions.CheckNotNull(hub, nameof(hub)),
             }, callSettings);
 
@@ -786,15 +786,15 @@ public virtual Hub GetHub(HubName name, gaxgrpc::CallSettings callSettings = nul
         /// Required. The initial values for a new hub.
         /// </param>
         /// <param name="hubId">
-        /// Optional. A unique identifier for the hub.
+        /// Required. A unique identifier for the hub.
         /// </param>
         /// <param name="callSettings">If not null, applies overrides to this RPC call.</param>
         /// <returns>A Task containing the RPC response.</returns>
         public virtual stt::Task<lro::Operation<Hub, OperationMetadata>> CreateHubAsync(string parent, Hub hub, string hubId, gaxgrpc::CallSettings callSettings = null) =>
             CreateHubAsync(new CreateHubRequest
             {
                 Parent = gax::GaxPreconditions.CheckNotNullOrEmpty(parent, nameof(parent)),
-                HubId = hubId ?? "",
+                HubId = gax::GaxPreconditions.CheckNotNullOrEmpty(hubId, nameof(hubId)),
                 Hub = gax::GaxPreconditions.CheckNotNull(hub, nameof(hub)),
             }, callSettings);
 
@@ -808,7 +808,7 @@ public virtual Hub GetHub(HubName name, gaxgrpc::CallSettings callSettings = nul
         /// Required. The initial values for a new hub.
         /// </param>
         /// <param name="hubId">
-        /// Optional. A unique identifier for the hub.
+        /// Required. A unique identifier for the hub.
         /// </param>
         /// <param name="cancellationToken">A <see cref="st::CancellationToken"/> to use for this RPC.</param>
         /// <returns>A Task containing the RPC response.</returns>
@@ -825,15 +825,15 @@ public virtual Hub GetHub(HubName name, gaxgrpc::CallSettings callSettings = nul
         /// Required. The initial values for a new hub.
         /// </param>
         /// <param name="hubId">
-        /// Optional. A unique identifier for the hub.
+        /// Required. A unique identifier for the hub.
         /// </param>
         /// <param name="callSettings">If not null, applies overrides to this RPC call.</param>
         /// <returns>The RPC response.</returns>
         public virtual lro::Operation<Hub, OperationMetadata> CreateHub(gagr::LocationName parent, Hub hub, string hubId, gaxgrpc::CallSettings callSettings = null) =>
             CreateHub(new CreateHubRequest
             {
                 ParentAsLocationName = gax::GaxPreconditions.CheckNotNull(parent, nameof(parent)),
-                HubId = hubId ?? "",
+                HubId = gax::GaxPreconditions.CheckNotNullOrEmpty(hubId, nameof(hubId)),
                 Hub = gax::GaxPreconditions.CheckNotNull(hub, nameof(hub)),
             }, callSettings);
 
@@ -847,15 +847,15 @@ public virtual Hub GetHub(HubName name, gaxgrpc::CallSettings callSettings = nul
         /// Required. The initial values for a new hub.
         /// </param>
         /// <param name="hubId">
-        /// Optional. A unique identifier for the hub.
+        /// Required. A unique identifier for the hub.
         /// </param>
         /// <param name="callSettings">If not null, applies overrides to this RPC call.</param>
         /// <returns>A Task containing the RPC response.</returns>
         public virtual stt::Task<lro::Operation<Hub, OperationMetadata>> CreateHubAsync(gagr::LocationName parent, Hub hub, string hubId, gaxgrpc::CallSettings callSettings = null) =>
             CreateHubAsync(new CreateHubRequest
             {
                 ParentAsLocationName = gax::GaxPreconditions.CheckNotNull(parent, nameof(parent)),
-                HubId = hubId ?? "",
+                HubId = gax::GaxPreconditions.CheckNotNullOrEmpty(hubId, nameof(hubId)),
                 Hub = gax::GaxPreconditions.CheckNotNull(hub, nameof(hub)),
             }, callSettings);
 
@@ -869,7 +869,7 @@ public virtual Hub GetHub(HubName name, gaxgrpc::CallSettings callSettings = nul
         /// Required. The initial values for a new hub.
         /// </param>
         /// <param name="hubId">
-        /// Optional. A unique identifier for the hub.
+        /// Required. A unique identifier for the hub.
         /// </param>
         /// <param name="cancellationToken">A <see cref="st::CancellationToken"/> to use for this RPC.</param>
         /// <returns>A Task containing the RPC response.</returns>
@@ -1404,15 +1404,15 @@ public virtual Spoke GetSpoke(SpokeName name, gaxgrpc::CallSettings callSettings
         /// Required. The initial values for a new spoke.
         /// </param>
         /// <param name="spokeId">
-        /// Optional. Unique id for the spoke to create.
+        /// Required. Unique id for the spoke to create.
         /// </param>
         /// <param name="callSettings">If not null, applies overrides to this RPC call.</param>
         /// <returns>The RPC response.</returns>
         public virtual lro::Operation<Spoke, OperationMetadata> CreateSpoke(string parent, Spoke spoke, string spokeId, gaxgrpc::CallSettings callSettings = null) =>
             CreateSpoke(new CreateSpokeRequest
             {
                 Parent = gax::GaxPreconditions.CheckNotNullOrEmpty(parent, nameof(parent)),
-                SpokeId = spokeId ?? "",
+                SpokeId = gax::GaxPreconditions.CheckNotNullOrEmpty(spokeId, nameof(spokeId)),
                 Spoke = gax::GaxPreconditions.CheckNotNull(spoke, nameof(spoke)),
             }, callSettings);
 
@@ -1426,15 +1426,15 @@ public virtual Spoke GetSpoke(SpokeName name, gaxgrpc::CallSettings callSettings
         /// Required. The initial values for a new spoke.
         /// </param>
         /// <param name="spokeId">
-        /// Optional. Unique id for the spoke to create.
+        /// Required. Unique id for the spoke to create.
         /// </param>
         /// <param name="callSettings">If not null, applies overrides to this RPC call.</param>
         /// <returns>A Task containing the RPC response.</returns>
         public virtual stt::Task<lro::Operation<Spoke, OperationMetadata>> CreateSpokeAsync(string parent, Spoke spoke, string spokeId, gaxgrpc::CallSettings callSettings = null) =>
             CreateSpokeAsync(new CreateSpokeRequest
             {
                 Parent = gax::GaxPreconditions.CheckNotNullOrEmpty(parent, nameof(parent)),
-                SpokeId = spokeId ?? "",
+                SpokeId = gax::GaxPreconditions.CheckNotNullOrEmpty(spokeId, nameof(spokeId)),
                 Spoke = gax::GaxPreconditions.CheckNotNull(spoke, nameof(spoke)),
             }, callSettings);
 
@@ -1448,7 +1448,7 @@ public virtual Spoke GetSpoke(SpokeName name, gaxgrpc::CallSettings callSettings
         /// Required. The initial values for a new spoke.
         /// </param>
         /// <param name="spokeId">
-        /// Optional. Unique id for the spoke to create.
+        /// Required. Unique id for the spoke to create.
         /// </param>
         /// <param name="cancellationToken">A <see cref="st::CancellationToken"/> to use for this RPC.</param>
         /// <returns>A Task containing the RPC response.</returns>
@@ -1465,15 +1465,15 @@ public virtual Spoke GetSpoke(SpokeName name, gaxgrpc::CallSettings callSettings
         /// Required. The initial values for a new spoke.
         /// </param>
         /// <param name="spokeId">
-        /// Optional. Unique id for the spoke to create.
+        /// Required. Unique id for the spoke to create.
         /// </param>
         /// <param name="callSettings">If not null, applies overrides to this RPC call.</param>
         /// <returns>The RPC response.</returns>
         public virtual lro::Operation<Spoke, OperationMetadata> CreateSpoke(gagr::LocationName parent, Spoke spoke, string spokeId, gaxgrpc::CallSettings callSettings = null) =>
             CreateSpoke(new CreateSpokeRequest
             {
                 ParentAsLocationName = gax::GaxPreconditions.CheckNotNull(parent, nameof(parent)),
-                SpokeId = spokeId ?? "",
+                SpokeId = gax::GaxPreconditions.CheckNotNullOrEmpty(spokeId, nameof(spokeId)),
                 Spoke = gax::GaxPreconditions.CheckNotNull(spoke, nameof(spoke)),
             }, callSettings);
 
@@ -1487,15 +1487,15 @@ public virtual Spoke GetSpoke(SpokeName name, gaxgrpc::CallSettings callSettings
         /// Required. The initial values for a new spoke.
         /// </param>
         /// <param name="spokeId">
-        /// Optional. Unique id for the spoke to create.
+        /// Required. Unique id for the spoke to create.
         /// </param>
         /// <param name="callSettings">If not null, applies overrides to this RPC call.</param>
         /// <returns>A Task containing the RPC response.</returns>
         public virtual stt::Task<lro::Operation<Spoke, OperationMetadata>> CreateSpokeAsync(gagr::LocationName parent, Spoke spoke, string spokeId, gaxgrpc::CallSettings callSettings = null) =>
             CreateSpokeAsync(new CreateSpokeRequest
             {
                 ParentAsLocationName = gax::GaxPreconditions.CheckNotNull(parent, nameof(parent)),
-                SpokeId = spokeId ?? "",
+                SpokeId = gax::GaxPreconditions.CheckNotNullOrEmpty(spokeId, nameof(spokeId)),
                 Spoke = gax::GaxPreconditions.CheckNotNull(spoke, nameof(spoke)),
             }, callSettings);
 
@@ -1509,7 +1509,7 @@ public virtual Spoke GetSpoke(SpokeName name, gaxgrpc::CallSettings callSettings
         /// Required. The initial values for a new spoke.
         /// </param>
         /// <param name="spokeId">
-        /// Optional. Unique id for the spoke to create.
+        /// Required. Unique id for the spoke to create.
         /// </param>
         /// <param name="cancellationToken">A <see cref="st::CancellationToken"/> to use for this RPC.</param>
         /// <returns>A Task containing the RPC response.</returns>