Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: unflake TestLIFOTakeWriteSessionOrder #1704

Closed
jeanbza opened this issue Dec 11, 2019 · 2 comments
Closed

spanner: unflake TestLIFOTakeWriteSessionOrder #1704

jeanbza opened this issue Dec 11, 2019 · 2 comments
Assignees
@hengfengli
Labels
api: spanner Issues related to the Spanner API. type: cleanup An internal cleanup or hygiene concern.
Milestone
Tests clean up

Comments

@jeanbza
Copy link
Member

jeanbza commented Dec 11, 2019

https://sponge.corp.google.com/target?id=12839dd0-c7d6-4a9c-a77d-64c962727111&target=cloud-devrel/client-libraries/go/google-cloud-go/presubmit/go113&searchFor=&show=ALL&sortBy=STATUS

--- FAIL: TestLIFOTakeWriteSessionOrder (0.17s)
    session_test.go:202: got session with id: projects/[PROJECT]/instances/[INSTANCE]/databases/[DATABASE]/sessions/3, want: projects/[PROJECT]/instances/[INSTANCE]/databases/[DATABASE]/sessions/2
@jeanbza jeanbza added api: spanner Issues related to the Spanner API. type: cleanup An internal cleanup or hygiene concern. labels Dec 11, 2019
@jeanbza jeanbza added this to the Tests clean up milestone Dec 11, 2019
gopherbot pushed a commit that referenced this issue Dec 11, 2019
@jeanbza
spanner: skip TestLIFOTakeWriteSessionOrder
bf32704 
Updates #1704

Change-Id: I41e73018352a7ae845eef5bb8628497a66ebb921
Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/49414
Reviewed-by: Jean de Klerk <deklerk@google.com>
@IlyaFaer
Copy link

Aleksandra already have a sign from @olavloite, in here:
#1688

@hengfengli
Copy link
Contributor

I probably close this one to avoid duplicated issues since it has been assigned in #1688.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hengfengli hengfengli

Labels
api: spanner Issues related to the Spanner API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
Tests clean up
Development

No branches or pull requests
3 participants
@hengfengli @jeanbza @IlyaFaer