Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add metadata to RowIterator #3050

Merged
merged 2 commits into from Oct 20, 2020

Conversation

olavloite
Copy link
Contributor

@olavloite olavloite commented Oct 19, 2020

Adds ResultSetMetaData to the RowIterator struct. The metadata are available after the first call to RowIterator.Next() as long as that call did not return any other error than iterator.Done.

Fixes #1805

Adds ResultSetMetaData to the RowIterator struct. The metadata
are available after the first call to RowIterator.Next() as long
as that call did not return any other error than iterator.Done.

Fixes #1805
@olavloite olavloite requested a review from hengfengli Oct 19, 2020
@olavloite olavloite requested a review from skuruppu as a code owner Oct 19, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2020
Copy link
Contributor

@hengfengli hengfengli left a comment

LGTM. Thanks a lot for fixing this!

@product-auto-label product-auto-label bot added the api: spanner Issues related to the Cloud Spanner API. label Oct 20, 2020
@olavloite olavloite merged commit 9a2289c into master Oct 20, 2020
2 checks passed
@olavloite olavloite deleted the spanner-add-metadata-to-row-iterator branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner: provide column types in results
2 participants