feat(bigquery): Add support for AllowNonIncrementalDefinition and Staleness on MaterializedView #8673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Staleness on MaterializedView
product-auto-label
bot
added
size: m
shollyman
reviewed
Oct 12, 2023
bigquery/table.go
Outdated
|
|
||
| // MaxStaleness of data that could be returned when materialized view | ||
| // is queried (formatted as Google SQL Interval type). | ||
| MaxStaleness string |
There was a problem hiding this comment.
Should we just use https://pkg.go.dev/cloud.google.com/go/bigquery#IntervalValue here and convert?
There was a problem hiding this comment.
that makes much more sense, thanks for the tip
alvarowolfx
added
the
do not merge
|
Thanks for adding this. Is there anything preventing this from getting merged? |
|
TODO: verify the behavior for maxStaleness at the table and within the MVD message. We may want to simply expose the top level message instead. |
product-auto-label
bot
added
the
stale: old
product-auto-label
bot
added
stale: extraold
|
Following up on this, hoping to get it in a release sooner than later |
alvarowolfx
removed
the
do not merge
shollyman
approved these changes
Jan 16, 2024
|
Thanks!! |
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8668