fix(bigtable): Accept nil RowSet to read all rows #9327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Conformance test failure at line
https://github.com/googleapis/cloud-bigtable-clients-test/blob/6b9ab96df64cf63898f8c1682a7e316aa23ef1b8/tests/readrows_test.go#L451-L453
:
Cause:
In a read rows request, a row set can be passed to specify which rows need to be read. E.g.:
https://github.com/googleapis/cloud-bigtable-clients-test/blob/6b9ab96df64cf63898f8c1682a7e316aa23ef1b8/tests/readrows_test.go#L485-L491
In the TestReadRows_Retry_StreamReset test, no row set has been specified:
https://github.com/googleapis/cloud-bigtable-clients-test/blob/6b9ab96df64cf63898f8c1682a7e316aa23ef1b8/tests/readrows_test.go#L436
In such cases, when the client library receives the read row request, it should not pass any RowSet in the ReadRows RPC call to Bigtable service.
But the Go test proxy creates infinite range and calls the ReadRows method.
Fix:
Logs after fix: