Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bigtable): Resolve DeadlineExceeded conformance test failures #9688

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Apr 2, 2024

This is similar to #9220

Before fix:

=== RUN   TestCheckAndMutateRow_Generic_DeadlineExceeded
[Servr log] 2024/04/02 10:51:58 There is 10s sleep on the server side
    checkandmutaterow_test.go:365: 
        	Error Trace:	/Users/bahaaiman/Documents/CNDB-Workspace-2/cloud-bigtable-clients-test/tests/checkandmutaterow_test.go:365
        	Error:      	Not equal: 
        	            	expected: 4
        	            	actual  : 2
        	Test:       	TestCheckAndMutateRow_Generic_DeadlineExceeded
--- FAIL: TestCheckAndMutateRow_Generic_DeadlineExceeded (2.01s)
=== RUN   TestMutateRow_Generic_DeadlineExceeded
[Servr log] 2024/04/02 10:52:00 There is 10s sleep on the server side
    mutaterow_test.go:290: 
        	Error Trace:	/Users/bahaaiman/Documents/CNDB-Workspace-2/cloud-bigtable-clients-test/tests/mutaterow_test.go:290
        	Error:      	Not equal: 
        	            	expected: 4
        	            	actual  : 2
        	Test:       	TestMutateRow_Generic_DeadlineExceeded
--- FAIL: TestMutateRow_Generic_DeadlineExceeded (2.01s)
=== RUN   TestSampleRowKeys_Generic_DeadlineExceeded
[Servr log] 2024/04/02 10:52:02 There is 10s sleep on the server side
    samplerowkeys_test.go:242: 
        	Error Trace:	/Users/bahaaiman/Documents/CNDB-Workspace-2/cloud-bigtable-clients-test/tests/samplerowkeys_test.go:242
        	Error:      	Not equal: 
        	            	expected: 4
        	            	actual  : 2
        	Test:       	TestSampleRowKeys_Generic_DeadlineExceeded
--- FAIL: TestSampleRowKeys_Generic_DeadlineExceeded (2.00s)
FAIL
exit status 1
FAIL	github.com/googleapis/cloud-bigtable-clients-test/tests	6.421s

After fix:

=== RUN   TestCheckAndMutateRow_Generic_DeadlineExceeded
[Servr log] 2024/04/02 10:55:41 There is 10s sleep on the server side
--- PASS: TestCheckAndMutateRow_Generic_DeadlineExceeded (2.01s)
=== RUN   TestMutateRow_Generic_DeadlineExceeded
[Servr log] 2024/04/02 10:55:43 There is 10s sleep on the server side
--- PASS: TestMutateRow_Generic_DeadlineExceeded (2.00s)
=== RUN   TestSampleRowKeys_Generic_DeadlineExceeded
[Servr log] 2024/04/02 10:55:45 There is 10s sleep on the server side
--- PASS: TestSampleRowKeys_Generic_DeadlineExceeded (2.01s)
PASS
ok  	github.com/googleapis/cloud-bigtable-clients-test/tests	6.396s

@bhshkh bhshkh requested review from a team as code owners April 2, 2024 17:56
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Apr 2, 2024
@bhshkh bhshkh added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 2, 2024
@bhshkh
Copy link
Contributor Author

bhshkh commented Apr 2, 2024

Do not merge until release freeze ends mid April

@bhshkh bhshkh removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 16, 2024
@bhshkh bhshkh requested a review from a team as a code owner April 16, 2024 17:53
@bhshkh bhshkh enabled auto-merge (squash) April 16, 2024 17:53
@bhshkh bhshkh merged commit 54d2990 into googleapis:main Apr 16, 2024
8 of 10 checks passed
@bhshkh bhshkh deleted the fix/cbt-conf-deadline-exceeded-fix branch April 16, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants