-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update hermetic build docker volume usage #10770
Closed
diegomarquezp
wants to merge
14
commits into
main
from
update-library-generation-docker-volume-usage
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
812d515
chore: update hermetic build docker volume usage
diegomarquezp 8255e65
remove redundant entrypoint sppecification
diegomarquezp cbc2ec6
test config change
diegomarquezp 167850d
fix docker image call
diegomarquezp 1d3caed
add another test for config change
diegomarquezp e01a95d
chore: generate libraries at Wed May 1 05:54:59 PM UTC 2024
diegomarquezp 6e4eb24
use current user
diegomarquezp 34577f8
restore test changes
diegomarquezp c4014d7
test change
diegomarquezp 60ef176
test change
diegomarquezp 30c697d
restore test changes
diegomarquezp d065f89
restore test changes 2
diegomarquezp 23fce07
prepare for next release of library_generation
diegomarquezp 592204f
restore test changes 3
diegomarquezp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -158,19 +158,11 @@ was modified (or the script exited because the library already existed). | |
|
||
The last step you need is to `cd` into the root of `google-cloud-java` and run | ||
``` | ||
docker volume create --name "repo-google-cloud-java" --opt "type=none" --opt "device=$(pwd)" --opt "o=bind" | ||
repo_volumes="-v repo-google-cloud-java:/workspace/google-cloud-java" | ||
docker run --rm \ | ||
${repo_volumes} \ | ||
-v /tmp:/tmp \ | ||
-v /var/run/docker.sock:/var/run/docker.sock \ | ||
-e "RUNNING_IN_DOCKER=true" \ | ||
-e "REPO_BINDING_VOLUMES=${repo_volumes}" \ | ||
gcr.io/cloud-devrel-public-resources/java-library-generation:latest \ | ||
python /src/generate_repo.py generate \ | ||
--generation-config-yaml=/workspace/google-cloud-java/generation_config.yaml \ | ||
--repository-path=/workspace/google-cloud-java \ | ||
--target-library-names=<library_name if specified; otherwise api_shortname> | ||
docker run --rm -u $(id -u):$(id -g) -v $(pwd):/workspace --entrypoint \ | ||
python gcr.io/cloud-devrel-public-resources/java-library-generation:latest \ | ||
/src/generate_repo.py generate \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you change this command to use |
||
--target-library-names=contentwarehouse \ | ||
--generation-config-yaml=/workspace/generation_config.yaml | ||
|
||
``` | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is the command enables us to modify/delete the docker generated files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, including ownership takeover performed by the container