Add createFromStream to Storage #186

mziccard · 2015-09-28T19:57:14Z

This PR follows the discussion we had in #172.
Changes are:

Modify StorageRpc.create to take an InputStream instead of a byte[]
StorageRpc.create modified to use direct upload
Add Storage.createFromStream method
Modify Storage.create to use Storage.createFromStream

Any feedback is much appreciated. I think we should clearly state in the javadoc that Storage.create and Storage.createFromStream use direct upload and must be therefore used only for small files. For bigger files BlobWriteChannel is the recommended choice.

gcloud-java-storage/src/main/java/com/google/gcloud/storage/Storage.java

@@ -501,6 +502,14 @@ public static Builder builder() {
  BlobInfo create(BlobInfo blobInfo, byte[] content, BlobTargetOption... options);

  /**
+   * Create a new blob.


Add createFromStream to Storage

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 454027580 Source-Link: googleapis/googleapis@1b22277 Source-Link: https://github.com/googleapis/googleapis-gen/commit/e04cea20d0d12eb5c3bdb360a9e72b654edcb638 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTA0Y2VhMjBkMGQxMmViNWMzYmRiMzYwYTllNzJiNjU0ZWRjYjYzOCJ9

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…oogleapis#186) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | major | `5.7.0` -> `6.0.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-resourcemanager).

… to v0.6.1 (googleapis#186) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-dataflow](https://togithub.com/googleapis/java-dataflow) | `0.6.0` -> `0.6.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataflow/0.6.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataflow/0.6.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataflow/0.6.1/compatibility-slim/0.6.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dataflow/0.6.1/confidence-slim/0.6.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-dataflow</summary> ### [`v0.6.1`](https://togithub.com/googleapis/java-dataflow/blob/HEAD/CHANGELOG.md#061-httpsgithubcomgoogleapisjava-dataflowcomparev060v061-2022-06-23) [Compare Source](https://togithub.com/googleapis/java-dataflow/compare/v0.6.0...v0.6.1) ##### Dependencies - update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#&googleapis#8203;181](https://togithub.com/googleapis/java-dataflow/issues/181)) ([70b89d7](https://togithub.com/googleapis/java-dataflow/commit/70b89d71adbee66241e43195d64f5a7ddb865870)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dataflow).

) * chore: update dependencies for regapic * add more dependencies and trigger comment * update goldens * fix indentation * remove duplicate gax-httpjson dependency * remove duplicated dependencies Source-Link: googleapis/synthtool@fa54eb2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:1ec28a46062b19135b11178ceee60231e5f5a92dab454e23ae0aab72cd875906

Source-Link: googleapis/synthtool@7a220e2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/3ed56491-ec66-4d43-9f98-af35b45c75fe/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@2414b81

🤖 I have created a release *beep* *boop* --- ## [1.3.0](googleapis/java-service-control@v1.2.0...v1.3.0) (2022-07-01) ### Features * Add Java REST transport to analytics, servicecontrol, servicemanagement, serviceusage and langauge APIs ([627df71](googleapis/java-service-control@627df71)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#186](googleapis/java-service-control#186)) ([4fc9a1d](googleapis/java-service-control@4fc9a1d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@18d4e9b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f8374176dc59291f05dd3fec927a9da2cda687a9ef4de32e77f699a2be12ab45

* docs: update the comments of various networksecurity resources fix!: fix annotation of parent in Create*Request PiperOrigin-RevId: 462271672 Source-Link: googleapis/googleapis@9213efa Source-Link: https://github.com/googleapis/googleapis-gen/commit/eb69561e8c95031d2f799285ed21bc65608eee96 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI2OTU2MWU4Yzk1MDMxZDJmNzk5Mjg1ZWQyMWJjNjU2MDhlZWU5NiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update pom.xml * deps: adding grpc-google-iam-v1 * deps: added grpc-google-common-protos Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Blake Li <blakeli@google.com> Co-authored-by: Tomo Suzuki <suztomo@google.com>

…transfer to v1.2.2 (#186) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-storage-transfer](https://togithub.com/googleapis/java-storage-transfer) | `1.2.1` -> `1.2.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage-transfer/1.2.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage-transfer/1.2.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage-transfer/1.2.2/compatibility-slim/1.2.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage-transfer/1.2.2/confidence-slim/1.2.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-storage-transfer</summary> ### [`v1.2.2`](https://togithub.com/googleapis/java-storage-transfer/blob/HEAD/CHANGELOG.md#122-httpsgithubcomgoogleapisjava-storage-transfercomparev121v122-2022-09-08) [Compare Source](https://togithub.com/googleapis/java-storage-transfer/compare/v1.2.1...v1.2.2) ##### Dependencies - Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#183](https://togithub.com/googleapis/java-storage-transfer/issues/183)) ([468d8fa](https://togithub.com/googleapis/java-storage-transfer/commit/468d8fa435893935f1c03c7083faa45717bb6fc2)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-storage-transfer).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jinja2](https://palletsprojects.com/p/jinja/) ([changelog](https://jinja.palletsprojects.com/changes/)) | `==3.0.3` -> `==3.1.2` | [![age](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/compatibility-slim/3.0.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/confidence-slim/3.0.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam-admin).

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 477955264 Source-Link: https://togithub.com/googleapis/googleapis/commit/a724450af76d0001f23602684c49cd6a4b3a5654 Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/4abcbcaec855e74a0b22a4988cf9e0eb61a83094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGFiY2JjYWVjODU1ZTc0YTBiMjJhNDk4OGNmOWUwZWI2MWE4MzA5NCJ9 fix!: Fix resource annotations for Cloud Deploy to use common resource name for locations This is technically a breaking change in that it's modifying the type for a resource, but it's a fast-follow fix to the earlier broken definition. PiperOrigin-RevId: 477192133 Source-Link: https://togithub.com/googleapis/googleapis/commit/f252e11bdab81146c67a7de4eddec412f18cd94f Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/34ca7cd6da0ac5920011c8bda01e8bc32b7da444 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzRjYTdjZDZkYTBhYzU5MjAwMTFjOGJkYTAxZThiYzMyYjdkYTQ0NCJ9 feat: Publish new JobRun resource and associated methods for Google Cloud Deploy PiperOrigin-RevId: 477144554 Source-Link: https://togithub.com/googleapis/googleapis/commit/59a30fb00d6142f88c6b9960e195ff33bc66776e Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/4edce039d3cffaa4202f6112d9caf6fc29dec0be Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGVkY2UwMzlkM2NmZmFhNDIwMmY2MTEyZDljYWY2ZmMyOWRlYzBiZSJ9

createFromStream added to Storage, StorageRpc.create uses InputStream

93b7a0c

mziccard added the api: storage Issues related to the Cloud Storage API. label Sep 28, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2015

aozarov reviewed Sep 28, 2015
View reviewed changes

gcloud-java-storage/src/main/java/com/google/gcloud/storage/Storage.java

@@ -501,6 +502,14 @@ public static Builder builder() {

BlobInfo create(BlobInfo blobInfo, byte[] content, BlobTargetOption... options);

/**

* Create a new blob.

This comment was marked as spam.

Sign in to view

mziccard added 2 commits September 29, 2015 18:05

javadoc: recommend Storage.writer for large uploads

82cd3ea

Rename Storage.createFromStream create, add create for empty content

86065a7

aozarov added a commit that referenced this pull request Sep 30, 2015

Merge pull request #186 from mziccard/add-storage-create-from-stream

1fa53a8

Add createFromStream to Storage

aozarov merged commit 1fa53a8 into googleapis:master Sep 30, 2015

aozarov mentioned this pull request Sep 30, 2015

Add create to Storage that takes an InputStream #172

Closed

github-actions bot pushed a commit that referenced this pull request Jul 14, 2022

chore: add native image checks as required (#186)

dbf19a1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add createFromStream to Storage #186

Add createFromStream to Storage #186

mziccard commented Sep 28, 2015

This comment was marked as spam.

Add createFromStream to Storage #186

Add createFromStream to Storage #186

Conversation

mziccard commented Sep 28, 2015

This comment was marked as spam.