Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Update download requester pays sample #2466

Merged
merged 4 commits into from
Oct 5, 2017
Merged

[Storage] Update download requester pays sample #2466

merged 4 commits into from
Oct 5, 2017

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Sep 27, 2017

This PR is to update the download sample for requester pays. It also fixes a object type mismatch in the commented section.

@jabubake if I missed something on updating another requester pays sample with the recent fixes please let me know and I'll resolve the issues.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 27, 2017
@frankyn
Copy link
Member Author

frankyn commented Sep 27, 2017

Found an issue in my PR. Fixing now.

@frankyn
Copy link
Member Author

frankyn commented Sep 27, 2017

PTAL, thank you.

jabubake
jabubake reviewed Sep 27, 2017
View reviewed changes
Copy link
Contributor

@jabubake jabubake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frank, can you also update
https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/google-cloud-examples/src/main/java/com/google/cloud/examples/storage/snippets/StorageSnippets.java#L1103 to use BucketField.BILLING to retrieve the Requester-Pays status ? Please merge after a google-cloud-java release, so that these updates are available in the release package.

...cloud-examples/src/main/java/com/google/cloud/examples/storage/snippets/StorageSnippets.java Outdated
@@ -66,6 +66,7 @@
import java.net.URL;
import java.nio.ByteBuffer;
import java.nio.file.Path;
import java.nio.file.Paths;

This comment was marked as spam.

Sign in to view

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 27, 2017
@frankyn
Copy link
Member Author

frankyn commented Sep 27, 2017

Signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 27, 2017
@frankyn
Copy link
Member Author

frankyn commented Sep 27, 2017

Thanks for your help @jabubake. I have updated the sample. PTAL.

@jabubake
Copy link
Contributor

LGTM : might want to hold on merge/ doc update till a google-cloud-java release is cut.

@frankyn
Copy link
Member Author

frankyn commented Sep 28, 2017

Thanks Jisha! Do you know when the next release will be out?

vam-google
vam-google approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankyn
Copy link
Member Author

frankyn commented Oct 4, 2017

Thanks @vam-google! I want to verify that the library was released and it should now contain the latest changes made for this PR to be able to merge. Is this the current state?

@vam-google
Copy link
Contributor

I think the release was completed 2 days ago. @neozwu please confirm. But in general I don't see any reasons to not push this change.

@jabubake
Copy link
Contributor

jabubake commented Oct 5, 2017

You are good to go on merge. See /releases for this repository

@frankyn frankyn merged commit ddcaaab into googleapis:master Oct 5, 2017
@frankyn frankyn deleted the update-requester-samples branch October 5, 2017 17:58
@frankyn
Copy link
Member Author

frankyn commented Oct 5, 2017

Thank you @vam-google and @jabubake!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabubake jabubake jabubake left review comments

@vam-google vam-google vam-google approved these changes

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frankyn @googlebot @jabubake @vam-google