Add service methods for immutable Compute resources and tests #696

mziccard · 2016-03-01T16:57:52Z

This PR adds spi and service methods for manipulating the following resources:

DiskType
MachineType
License
Zone
Region

In c18730c integration tests are also added.

mziccard · 2016-03-01T18:44:15Z

I think the coverage drop is the usual one we see when we add the spi layer that is only tested through ITs (which do not concur to compute the coverage).

gcloud-java-compute/src/main/java/com/google/gcloud/spi/DefaultComputeRpc.java

+      ImmutableList.Builder<DiskType> builder = ImmutableList.builder();
+      Map<String, DiskTypesScopedList> scopedList = aggregatedList.getItems();
+      if (scopedList != null) {
+        for (String key : scopedList.keySet()) {


aozarov · 2016-03-04T04:30:08Z

Nice work! Done with first iteration. Any reason we don't have codacy analysis here?

mziccard · 2016-03-04T12:49:02Z

@aozarov I addressed the comments in ff8feb5

Add support for filters: filter method to options + filter classes
Removed unnecessary fields + added missing ones
Removed redundant "throws" from method signatures
Add static method in DefaultComputeRpc to handle the NOT_FOUND case

I also had to add dedicated option classes for aggregated lists as fields option is not completely supported (see #711).

gcloud-java-compute/src/main/java/com/google/gcloud/compute/Compute.java

+    private final ComparisonOperator operator;
+    private final Object value;
+
+    enum ComparisonOperator {


aozarov · 2016-03-08T05:33:12Z

Looks good. Few minor comments. Feel free to merge after they are resolved.

- Add missing resource fields and remove non-needed ones - Add selector classes and selector options - Add dedicated option classes for aggregated options - Remove unnecessary "throws" from method signature - Add static function to handle 404 exceptions

Add service methods for immutable Compute resources and tests

…onfig to v1.2.5 (googleapis#696) * build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.2.5 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@7a220e2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6d4e3a15c62cfdcb823d60e16da7521e7c6fc00eba07c8ff12e4de9924a57d28

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Making CLIRR not required. The version bumps are now controlled by the Release Please and OwlBot. The CL authors create appropriate change description to control major version bumps.

🤖 I have created a release *beep* *boop* --- ## [1.11.0](googleapis/java-compute@v1.10.0...v1.11.0) (2022-06-30) ### Features * Update Compute Engine API to revision 20220526 ([googleapis#722](googleapis/java-compute#722)) ([b409524](googleapis/java-compute@b409524)) ### Bug Fixes * **compute:** remove proto3_optional from parent_id ([googleapis#712](googleapis/java-compute#712)) ([b409524](googleapis/java-compute@b409524)) * **compute:** replace missing REQUIRED for parent_id ([googleapis#711](googleapis/java-compute#711)) ([b409524](googleapis/java-compute@b409524)) * **compute:** revert proto3_optional, required removal on parent_id ([googleapis#714](googleapis/java-compute#714)) ([b409524](googleapis/java-compute@b409524)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#697](googleapis/java-compute#697)) ([f708f6b](googleapis/java-compute@f708f6b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@18d4e9b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f8374176dc59291f05dd3fec927a9da2cda687a9ef4de32e77f699a2be12ab45

…plugin to v3 (#696) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-deploy-plugin](https://maven.apache.org/plugins/) | `2.8.2` -> `3.0.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/compatibility-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/confidence-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-game-servers).

…-plugin to v3.4.1 (#696) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-javadoc-plugin/3.4.1/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-webrisk).

…1.1 (#696) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.0` -> `26.1.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/compatibility-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/confidence-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-billing).

mziccard added the api: compute Issues related to the Compute Engine API. label Mar 1, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2016

mziccard added 2 commits March 1, 2016 19:24

Add service methods for immutable Compute resources

8073b20

Add RemoteComputeHelper and integration tests

3af1497

mziccard force-pushed the compute branch from c18730c to 3af1497 Compare March 1, 2016 18:30

aozarov reviewed Mar 1, 2016
View reviewed changes

mziccard force-pushed the compute branch from 28ed6e8 to ff8feb5 Compare March 4, 2016 15:50

aozarov reviewed Mar 8, 2016
View reviewed changes

mziccard force-pushed the compute branch from ff8feb5 to 8ee83d8 Compare March 8, 2016 12:00

Refactor compute service

29f35f7

- Add missing resource fields and remove non-needed ones - Add selector classes and selector options - Add dedicated option classes for aggregated options - Remove unnecessary "throws" from method signature - Add static function to handle 404 exceptions

mziccard force-pushed the compute branch from 8ee83d8 to 29f35f7 Compare March 8, 2016 12:02

mziccard added a commit that referenced this pull request Mar 8, 2016

Merge pull request #696 from mziccard/compute

4e16b54

Add service methods for immutable Compute resources and tests

mziccard merged commit 4e16b54 into googleapis:compute-alpha Mar 8, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add service methods for immutable Compute resources and tests #696

Add service methods for immutable Compute resources and tests #696

mziccard commented Mar 1, 2016

mziccard commented Mar 1, 2016

This comment was marked as spam.

aozarov commented Mar 4, 2016

mziccard commented Mar 4, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Mar 8, 2016

Add service methods for immutable Compute resources and tests #696

Add service methods for immutable Compute resources and tests #696

Conversation

mziccard commented Mar 1, 2016

mziccard commented Mar 1, 2016

This comment was marked as spam.

aozarov commented Mar 4, 2016

mziccard commented Mar 4, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

aozarov commented Mar 8, 2016