Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change in minor release of @google-cloud/secret-manager 5.4.0 #5289

Closed
mnahkies opened this issue Apr 29, 2024 · 2 comments · Fixed by #5290
Closed

Breaking change in minor release of @google-cloud/secret-manager 5.4.0 #5289

mnahkies opened this issue Apr 29, 2024 · 2 comments · Fixed by #5290

Comments

@mnahkies
Copy link

A method was renamed by https://github.com/googleapis/google-cloud-node/pull/5273/files#diff-58dd618354fa97803f0fa5355182bc50d81235cca30945857c179071555ebfd1L2213-R2343 in a backwards incompatible way.

Environment details

  • which product (packages/*): @google-cloud/secret-manager
  • google-cloud-node version: 5.4.0

Steps to reproduce

Public method secretVersionPath was renamed to projectLocationSecretSecretVersionPath in a minor release.

Ideally the previous name would be kept for backwards compatibility.
@mattkindy
Copy link

Having this issue as well

TypeError: client.secretVersionPath is not a function

@sofisl
Copy link
Contributor

sofisl commented Apr 29, 2024

Looking!

This was referenced Apr 29, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: (secretmanaer) readd legacy path templates googleapis/google-cloud-node
3 participants
@mnahkies @mattkindy @sofisl