Use assertArrayHasKey and assertArrayNotHasKey (#774)

googleapis · Dec 6, 2017 · 131def5 · 131def5
1 parent f78b8ba
commit 131def5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/tests/unit/Datastore/EntityMapperTest.php b/tests/unit/Datastore/EntityMapperTest.php
@@ -541,7 +541,7 @@ public function testValueExcludeFromIndexes()
 
         $res = $this->mapper->valueObject('hello', false);
 
-        $this->assertFalse(isset($res['excludeFromIndexes']));
+        $this->assertArrayNotHasKey('excludeFromIndexes', $res);
     }
 
     public function testObjectPropertyBlob()

diff --git a/tests/unit/Datastore/EntityTest.php b/tests/unit/Datastore/EntityTest.php
@@ -54,11 +54,11 @@ public function testCreateEntity()
 
         $this->assertNull($entity['doesntExist']);
 
-        $this->assertFalse(isset($entity['doesntExist']));
-        $this->assertTrue(isset($entity['test']));
+        $this->assertArrayNotHasKey('doesntExist', $entity);
+        $this->assertArrayHasKey('test', $entity);
 
         unset($entity['test']);
-        $this->assertFalse(isset($entity['test']));
+        $this->assertArrayNotHasKey('test', $entity);
 
         $entity->magicProperty = 'magic value';
         $this->assertEquals('magic value', $entity->magicProperty);