feat: Add support for batch session creation in Cloud Spanner #2342
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2342 +/- ##
============================================
+ Coverage 92.53% 92.54% +0.01%
- Complexity 4501 4502 +1
============================================
Files 312 312
Lines 13479 13488 +9
============================================
+ Hits 12473 12483 +10
+ Misses 1006 1005 -1
Continue to review full report at Codecov.
|
| @@ -643,31 +649,19 @@ private function getSession(array &$data) | |||
| */ | |||
| private function createSessions($count) | |||
| { | |||
| $args = [ | |||
| $res = $this->database->connection()->batchCreateSessions([ | |||
There was a problem hiding this comment.
This will need to be called in a while loop since it's possible for batchCreateSessions to return fewer than $count sessions.
| @@ -643,31 +649,19 @@ private function getSession(array &$data) | |||
| */ | |||
| private function createSessions($count) | |||
| { | |||
| $args = [ | |||
| $res = $this->database->connection()->batchCreateSessions([ | |||
There was a problem hiding this comment.
Also, does the PHP client use more than one gRPC channel? If so, we want to distribute the sessions as evenly as possible across the channels. No problem if only one channel is used in this implementation.
There was a problem hiding this comment.
PHP only uses a single gRPC channel per request lifecycle.
jdpedrie
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
No description provided.