Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Authenticated Push #2354

Merged
merged 2 commits into from
Oct 1, 2019
Merged

feat: Add support for Authenticated Push #2354

merged 2 commits into from
Oct 1, 2019

Conversation

jdpedrie
Copy link
Contributor

Tests will not pass until googleapis/google-auth-library-php#243 is merged and released.

@jdpedrie jdpedrie added the api: pubsub Issues related to the Pub/Sub API. label Sep 26, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2019
@jdpedrie jdpedrie added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2019
@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #2354 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2354      +/-   ##
============================================
+ Coverage     92.53%   92.54%   +0.01%     
- Complexity     4501     4502       +1     
============================================
  Files           312      312              
  Lines         13479    13488       +9     
============================================
+ Hits          12473    12483      +10     
+ Misses         1006     1005       -1
Impacted Files Coverage Δ Complexity Δ
PubSub/src/Subscription.php 100% <ø> (ø) 40 <0> (ø) ⬇️
Spanner/src/Connection/Grpc.php 94.35% <0%> (+0.11%) 95% <0%> (+1%) ⬆️
Spanner/src/Session/CacheSessionPool.php 97.84% <0%> (+0.35%) 88% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e86c6...8836391. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants