Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ordering keys #2624

Merged
merged 3 commits into from
Jan 30, 2020
Merged

feat: add support for ordering keys #2624

merged 3 commits into from
Jan 30, 2020

Conversation

jdpedrie
Copy link
Contributor

replaces #2419. This PR demonstrates using a single batch job for multiple ordering keys RPCs in order to prevent crashes from exhausted shared memory.

Opening as a separate PR so that the changes may be compared.

@jdpedrie jdpedrie added the api: pubsub Issues related to the Pub/Sub API. label Jan 21, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2020
@jdpedrie jdpedrie changed the title feat: Add support for ordering keys. feat: add support for ordering keys. Jan 21, 2020
@hongalex
Copy link
Member

I think conventional commits is complaining about the period at the end of the sentence.

@jdpedrie jdpedrie changed the title feat: add support for ordering keys. feat: add support for ordering keys Jan 23, 2020
PubSub/tests/Snippet/MessageBuilderTest.php Outdated Show resolved Hide resolved
PubSub/tests/Unit/MessageBuilderTest.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants