Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(Firestore): Upgrade Firestore V2 #7299

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat!(Firestore): Upgrade Firestore V2 #7299

wants to merge 4 commits into from

Conversation

yash30201
Copy link
Contributor

@yash30201 yash30201 commented May 8, 2024

Firestore Library Upgrade


Main PR for all the Firestore v2 upgrade.

Part 1 [✅]

PR: #7298

This PR contains all the additive changes to the library laying the ground work for the further work.

  • Add gapic client configs.
  • Add credentials wrapper support.
  • Add root serializer and request handler.
  • Update resource classes to add serializer and request handler to:
    • Constructors
    • Instantiations
  • Add serializer and request handler support in all the snippet and unit tests.
  • Update core's version to a future non existent version

Part 2 [✅]

PR: #7300

Update the 9 RPCs exposed by Grpc connection class and correspondingly update their unit and system tests.

Part 3 [✅]

PR: #7418

Do the rest of the work like:

  • Update the system tests if something breaks
  • Add MIGRATION.md file
  • Update the documentation whereever required.
    • Snippets
    • Doc blocks
    • FirestoreClient constructor's documentation
  • Remove old GAPIC files
    • Class aliases
    • Gapic client
  • Update core's version to the next future version.
  • Mark classes as @internal where ever required.

BREAKING_CHANGE_REASON=RC-1 for the version 2 of the Firestore Library

* Add Gapic client config

* Add credentials wrapper support.

* Add root serializer and request handler

* Update resource classes to add serializer and request handler

* Add serializer and request handler support in all the snippet and unit tests

* Update core's version to a future non existent version
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label May 8, 2024
- Update Migration guide
- Update documentation
- Remove class aliases
@yash30201 yash30201 marked this pull request as ready for review June 13, 2024 13:20
@yash30201 yash30201 requested review from a team as code owners June 13, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant