Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: [Spanner] Upgrade to V2 (Part 2/2) #7360

Merged
merged 41 commits into from
Jun 7, 2024
Merged

feat!: [Spanner] Upgrade to V2 (Part 2/2) #7360

merged 41 commits into from
Jun 7, 2024

Conversation

ajupazhamayil
Copy link
Contributor

@ajupazhamayil ajupazhamayil commented Jun 3, 2024 •
edited
Loading

Spanner V2 : Part 2

  • Replacing Connection object with RequestHandler [Backup class]
  • Replacing Connection object with RequestHandler [Instance class]
  • Replacing Connection object with RequestHandler [InstanceConfiguration class]
  • Replacing Connection object with RequestHandler [SpannerClient]
  • Remove Connection Classes and Directory 🎉
  • System tests
  • Unit tests
  • Snippet tests

Related work:

  • Migration.md file

@ajupazhamayil
feat!: [Spanner] Upgrade to PHP V2
0f9b3b7
@ajupazhamayil
add RequestHandler to SpannerClient
37076aa
@ajupazhamayil
make LRO work for create database operation
f9fb788
@ajupazhamayil
Replace Connection class in Database.php
6ae9e61
@ajupazhamayil
Replace Conncection class objects in Operation and Session classess
4bed2dd
@ajupazhamayil
Resolve unittest issues in TransactionTypeTest and TransactionTest
996fecf
@ajupazhamayil
Resolve System/AdminTest issues
dd44928
@ajupazhamayil
Resolve System test issues: BatchTest
dd83885
@ajupazhamayil
Resolve system/TransactionTest issues
0966a99
@ajupazhamayil
resolve system tests issues of CacheSessionPool
5b9841d
@ajupazhamayil
make requestHandler return Promise
c555140
@ajupazhamayil
Resolve styling issues
143e700
@ajupazhamayil
Resolve PG tests
677d853
@ajupazhamayil
rename LROManagerTrait to LongRunningOperationTrait
1bb522e
@ajupazhamayil
Remove extra decodeMessages
560d12e
@ajupazhamayil
Resolve system tests issues
3da94d1
@ajupazhamayil
Improve code readablity
aca7c7a
@ajupazhamayil
Resolve unit test issues
d254501
@ajupazhamayil
remove scopes to see the unit tests failures
5b440b4
@ajupazhamayil
rollback the changes for testing
0fcd821
@ajupazhamayil
Fix tests/Unit/DatabaseTest.php
a743df5
@ajupazhamayil
Remove projectId from the DatabaseTest
6ddc272
@ajupazhamayil
Resolve unittest ADC issues
abf2102
@ajupazhamayil
make the unittests pass
8dd9cfe
@ajupazhamayil
feat(Spanner)!: Remove connection classes
4f31664
@ajupazhamayil
Resolve system tests
74404c2
@ajupazhamayil
Resolve styling issues
2dd0761
@ajupazhamayil
Copy link
Contributor Author

Adding a link to part1 here: #7193

@ajupazhamayil ajupazhamayil marked this pull request as ready for review June 7, 2024 10:45
@ajupazhamayil ajupazhamayil requested review from a team as code owners June 7, 2024 10:45
@ajupazhamayil ajupazhamayil merged commit f6256e6 into spanner-v2 Jun 7, 2024
18 of 19 checks passed
@ajupazhamayil ajupazhamayil deleted the spanner-v2-part2 branch June 7, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ajupazhamayil