Bigtable: Create snippets bigtable table.py #6484

sangramql · 2018-11-13T14:11:44Z

Create snippets for table.py

…le-cloud-python into snippets_bigtable

sangramql · 2018-11-13T14:25:59Z

@tseaver , @AVaksman Please review the snippets for table.py

sangramql · 2018-11-13T22:08:46Z

@sduskis Please review the snippets.

bigtable/docs/snippets.py

+    instance = client.instance(INSTANCE_ID)
+
+    table = instance.table("table_id1_samplerow")
+    table.create()


bigtable/docs/snippets.py

+    assert column_family_id in col_fams
+
+
+def test_bigtable_mutations_batcher_read_rows():


bigtable/docs/snippets.py

+        expected_rows_data.append(row.decode('utf-8'))
+        expected_rows_data.append(cell_val.decode('utf-8'))
+
+    # [START bigtable_mutate_rows]


bigtable/docs/snippets.py

+    table_name = table.name
+    # [END bigtable_table_name]
+
+    cred = os.environ.get('GOOGLE_APPLICATION_CREDENTIALS', 'project_id')


sangramql · 2018-11-16T10:14:05Z

@tseaver, @AVaksman Please review the changes made according to the review.

bigtable/docs/snippets.py

+    actual_keys, offset = zip(*[(rk.row_key, rk.offset_bytes) for rk in data])
+    # [END bigtable_sample_row_keys]
+    initial_split_keys.append(b'')
+    assert actual_keys == initial_split_keys


AVaksman · 2018-11-16T21:21:00Z

When I run test locally I get an error ServiceUnavailable: 503 The service is currently unavailable. by drop_by_prefix and truncates.

sangramql · 2018-11-16T21:39:31Z

I am running on emulators, so worked fine. My rpc calls are broken so unable to test on cloud.

AVaksman · 2018-11-18T18:20:12Z

After consulting with @sduskis, it looks like it might have something to do with the instance becoming replicated. As such, switching tests around seems to fix the problem. Please move test_bigtable_table_row() up right after test_bigtable_mutations_batcher() and move test_bigtable_create_additional_cluster() at the very end.

AVaksman · 2018-11-19T18:05:14Z

If this suggestion is agreed with. Please create separate instances for admin and data snippet tests rather than switching tests order.

sangramql · 2018-11-22T04:22:34Z

If that's the case then it looks ideal for creating separate snippets files for instance admin and table admin.

In which case, there would be separate setup and teardown. which would handle new instance for separate files.

sangramql · 2018-11-22T05:26:58Z

@tseaver, @AVaksman, please review the changes.
As there was conflict with same instance while using the table admin and instance admin snippets, I have created separate snippets files. If you still feel we should go with single file, please suggests, I'll merge it into single file.

crwilcox · 2018-11-28T22:27:39Z

Bigtable gets its noxfile from the synthtool templates. You will want to alter the last line of synth.py from

s.move(templated_files) to s.move(templated_files, excludes=['noxfile.py']) as you are adding a snippets target which isn't currently part of the template.

sangramql · 2018-12-04T23:05:08Z

Bigtable gets its noxfile from the synthtool templates. You will want to alter the last line of synth.py from

s.move(templated_files) to s.move(templated_files, excludes=['noxfile.py']) as you are adding a snippets target which isn't currently part of the template.

@crwilcox
Done.

sangramql · 2018-12-09T22:26:20Z

@tseaver could you please review this code?

bigtable/noxfile.py

+
+@nox.session(python=['2.7', '3.7'])
+def snippets(session):
+    """Run the system test suite."""


bigtable/noxfile.py

+@nox.session(python=['2.7', '3.7'])
+def snippets(session):
+    """Run the system test suite."""
+    # Sanity check: Only run system tests if the environment variable is set.


tseaver · 2018-12-12T18:47:19Z

My two requested changes are minor. Merge when CI is green after making them.

sangramql · 2018-12-17T18:10:05Z

@sduskis Thank you for update. My apologies, I missed the notification.

sangramql added 6 commits November 5, 2018 17:33

add snippets for table.py

817ae74

add snippets for table.py

1ca1473

add more table snippets

8a32ab5

rectify nox file

1c8bafa

add more snippets for table

23576ad

add more snippets for table

6873f16

sangramql requested review from crwilcox, dhermes and tseaver as code owners November 13, 2018 14:11

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2018

sangramql and others added 3 commits November 13, 2018 19:43

Merge branch 'master' into snippets_bigtable

59ed6d7

change s___test_bigtable to test_bigtable tests

d785687

Merge branch 'snippets_bigtable' of https://github.com/sangramql/goog…

6a2d3c4

…le-cloud-python into snippets_bigtable

AVaksman reviewed Nov 14, 2018

View reviewed changes

AVaksman reviewed Nov 15, 2018

View reviewed changes

bigtable/docs/snippets.py Outdated

table_name = table.name

# [END bigtable_table_name]

cred = os.environ.get('GOOGLE_APPLICATION_CREDENTIALS', 'project_id')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

sangramql added 2 commits November 15, 2018 21:15

fix table snippets as per review

73c0604

fix reviews

a68b268

sangramql changed the title ~~Bigtable: Create snippets bigtable table.py~~ Bigtable: Create snippets bigtable table.py (Work in progress, plz hold on further review) Nov 15, 2018

sangramql added 3 commits November 16, 2018 13:20

Fix reviews

b384378

Fix reviews

8c29c67

Fix reviews

6bda107

sangramql changed the title ~~Bigtable: Create snippets bigtable table.py (Work in progress, plz hold on further review)~~ Bigtable: Create snippets bigtable table.py Nov 16, 2018

Fix reviews

927a22e

AVaksman reviewed Nov 16, 2018

View reviewed changes

fix reviews

418db0f

tseaver added the api: bigtable Issues related to the Bigtable API. label Nov 21, 2018

sangramql added 4 commits November 22, 2018 10:43

separate files for table.py and instance admin

22e2b69

separate files for table.py and instance admin

ad62796

separate files for table.py and instance admin

2e8593b

separate files for table.py and instance admin

07fff76

separate files for table.py and instance admin

5fba7fb

crwilcox and others added 3 commits November 28, 2018 14:33

Merge branch 'master' into snippets_bigtable

654c6fc

Modify synth to exclude noxfile

38a2c3f

Merge branch 'master' into snippets_bigtable

229ed4c

sangramql mentioned this pull request Dec 10, 2018

Bigtable: Create Column Family snippets #6571

Closed

tseaver reviewed Dec 12, 2018

View reviewed changes

Updating nox.py comments

4bc19db

tseaver merged commit 8f3d5c7 into googleapis:master Dec 17, 2018

sangramql deleted the snippets_bigtable branch December 21, 2018 07:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bigtable: Create snippets bigtable table.py #6484

Bigtable: Create snippets bigtable table.py #6484

sangramql commented Nov 13, 2018

sangramql commented Nov 13, 2018

sangramql commented Nov 13, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

sangramql commented Nov 16, 2018

This comment was marked as spam.

This comment was marked as spam.

AVaksman commented Nov 16, 2018

sangramql commented Nov 16, 2018

AVaksman commented Nov 18, 2018

AVaksman commented Nov 19, 2018 •

edited

Loading

sangramql commented Nov 22, 2018

sangramql commented Nov 22, 2018 •

edited

Loading

crwilcox commented Nov 28, 2018

sangramql commented Dec 4, 2018

sangramql commented Dec 9, 2018

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Dec 12, 2018

sangramql commented Dec 17, 2018

		assert column_family_id in col_fams


		def test_bigtable_mutations_batcher_read_rows():

Bigtable: Create snippets bigtable table.py #6484

Bigtable: Create snippets bigtable table.py #6484

Conversation

sangramql commented Nov 13, 2018

sangramql commented Nov 13, 2018

sangramql commented Nov 13, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

sangramql commented Nov 16, 2018

This comment was marked as spam.

This comment was marked as spam.

AVaksman commented Nov 16, 2018

sangramql commented Nov 16, 2018

AVaksman commented Nov 18, 2018

AVaksman commented Nov 19, 2018 • edited Loading

sangramql commented Nov 22, 2018

sangramql commented Nov 22, 2018 • edited Loading

crwilcox commented Nov 28, 2018

sangramql commented Dec 4, 2018

sangramql commented Dec 9, 2018

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Dec 12, 2018

sangramql commented Dec 17, 2018

AVaksman commented Nov 19, 2018 •

edited

Loading

sangramql commented Nov 22, 2018 •

edited

Loading