Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tasks: Add working example for 'create_queue' #7025

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Tasks: Add working example for 'create_queue' #7025

merged 1 commit into from
Jan 3, 2019

Conversation

msdinit
Copy link
Contributor

@msdinit msdinit commented Dec 28, 2018 •
edited
Loading

This example is consistent with a similar change implemented in nodejs version here: googleapis/nodejs-tasks#142

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 28, 2018
@tseaver tseaver changed the title Add working example for cloud tasks create_queue Tasks: Add working example for 'create_queue' Jan 3, 2019
@tseaver tseaver added type: docs Improvement to the documentation for an API. api: cloudtasks Issues related to the Cloud Tasks API. labels Jan 3, 2019
@tseaver tseaver merged commit 2a1341c into googleapis:master Jan 3, 2019
@tseaver
Copy link
Contributor

tseaver commented Jan 5, 2019

@msdinit Thanks for the patch! Unfortunately, that docstring is in a module which is generated from the comments in the relevant .proto file, and will get overwritten by subsequent auto-generation runs (see #7057).

@tseaver tseaver mentioned this pull request Jan 5, 2019
Closed
@tseaver
Copy link
Contributor

tseaver commented Jan 5, 2019

Also, now that I look at it, the doctest example is actually invalid: it needs ... as the prefix for the lines inside the opened {.

tseaver added a commit that referenced this pull request Jan 5, 2019
@tseaver
Restore expanded example from PR #7025 after synth. (#7062)
b70281e 
Also, remove now-spurious replacements.

Supersedes #7057.
parthea pushed a commit that referenced this pull request Sep 22, 2023
@msdinit @tseaver
Add working example for 'create_queue'. (#7025)
9c9a435
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
Restore expanded example from PR #7025 after synth. (#7062)
870bf6a 
Also, remove now-spurious replacements.

Supersedes #7057.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: cloudtasks Issues related to the Cloud Tasks API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msdinit @tseaver @googlebot