Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate tests #7528

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Remove duplicate tests #7528

merged 1 commit into from
Mar 19, 2019

Conversation

sethtroisi
Copy link
Contributor

found with grep -ri "def test" bigtable/docs/snippets_table.py | sort | uniq -c | sort -n

these tests are duplicated inside the file

test_bigtable_column_family_name was at line 415 and line 491
test_bigtable_create_update_delete_column_family was at line 438 and line 514
test_bigtable_row_clear was at line 1084 and line 1239

Part of #7522

found with grep -ri "def test" bigtable/docs/snippets_table.py | sort | uniq -c | sort -n
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2019
@tseaver tseaver added testing api: bigtable Issues related to the Bigtable API. type: docs Improvement to the documentation for an API. labels Mar 19, 2019
@tseaver tseaver merged commit 2b2a255 into googleapis:master Mar 19, 2019
@tseaver
Copy link
Contributor

tseaver commented Mar 19, 2019

Thanks very much for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. testing type: docs Improvement to the documentation for an API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants