Pub/Sub: document regional endpoint #8789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
plamut
reviewed
Jul 26, 2019
There was a problem hiding this comment.
Please comment on if this is enough documentation on regional endpoint re configuring it.
Depends on who reported this, what level of detail is expected?
In a vacuum, the addition looks fine to me. Perhaps just make it a tad more clear with an example?
... single key-value pair of name `api_endpoint`, e.g. `client_options={"api_endpoint": REGIONAL_ENDPOINT}`
tseaver
added
api: pubsub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please comment if this is enough documentation for showing how to configure regional endpoint.
I could take this opportunity to document other
kwargsif needed, but it's recommended that users don't touch those.