Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix links to googleapis.dev #8998

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Docs: Fix links to googleapis.dev #8998

merged 1 commit into from
Aug 9, 2019

Conversation

busunkim96
Copy link
Contributor

Closes #8993

Will be followed by release PRs to update links on PyPI.

@busunkim96 busunkim96 added api: cloudtrace Issues related to the Cloud Trace API. api: cloudtasks Issues related to the Cloud Tasks API. api: cloudkms Issues related to the Cloud Key Management Service API. api: cloudasset Issues related to the Cloud Asset Inventory API. api: scheduler labels Aug 8, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2019
@busunkim96 busunkim96 added type: docs Improvement to the documentation for an API. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 8, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2019
tseaver
tseaver approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh! Why have we agreed to inject that bit of off-branding into our URLs?

@busunkim96
Copy link
Contributor Author

I decided to use the api_endoint/service address for consistency. (And some of the APIs use cloud* unfortunately). 😢

@busunkim96 busunkim96 merged commit 083ee9c into googleapis:master Aug 9, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@busunkim96 @emar-kar
Fix links to googleapis.dev (googleapis#8998)
a45eb50
parthea pushed a commit that referenced this pull request Sep 22, 2023
@busunkim96
Fix links to googleapis.dev (#8998)
bd5ba0d
parthea pushed a commit that referenced this pull request Sep 22, 2023
@busunkim96
Fix links to googleapis.dev (#8998)
9fac022
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
Fix links to googleapis.dev (#8998)
b010202
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
Fix links to googleapis.dev (#8998)
09c451f
parthea pushed a commit that referenced this pull request Oct 22, 2023
@busunkim96
Fix links to googleapis.dev (#8998)
3641e49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API. api: cloudkms Issues related to the Cloud Key Management Service API. api: cloudtasks Issues related to the Cloud Tasks API. api: cloudtrace Issues related to the Cloud Trace API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KMS: Documentation link on googleapis.dev is missing.
3 participants
@busunkim96 @tseaver @googlebot