Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): Respect custom endpoint for signed_url #25469

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

bajajneha27
Copy link
Contributor

When a custom endpoint is set on the client, Sign URLs and Post Policies automatically use that domain.

closes: #23528

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Apr 3, 2024
@bajajneha27 bajajneha27 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Apr 3, 2024
@bajajneha27 bajajneha27 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 19, 2024
Copy link

@BrennaEpp BrennaEpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll let Ruby folk approve

Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bajajneha27 bajajneha27 merged commit e95b075 into googleapis:main Apr 24, 2024
15 checks passed
@yoshi-approver yoshi-approver added the release-please:force-run To run release-please label Apr 24, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: Support custom endpoints for SignURLs
4 participants