-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: native image configs for google-http-java-client #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
Pull request size is extra large.
and removed
size: l
Pull request size is large.
labels
Nov 6, 2023
Warning: This pull request is touching the following templated files:
|
mpeddada1
changed the title
fix: native image configs for google-http-java-client [WIP]
fix: native image configs for google-http-java-client
Nov 6, 2023
burkedavison
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve with request to remove System.out.printlns
mpeddada1
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 6, 2023
mpeddada1
added
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Nov 6, 2023
mpeddada1
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
and removed
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
kokoro:run
Add this label to force Kokoro to re-run the tests.
labels
Nov 7, 2023
mpeddada1
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
and removed
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Nov 7, 2023
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 7, 2023
mpeddada1
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 7, 2023
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes on class initialization:
To run tests with native image compilation:
mvn test -Pnative -Pnative-deps
.Please Note
This PR doesn't include native image support for
google-http-java-client-appengine
yet which is still running into: