Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a static compile method to UriTemplate.java #42

Closed
wonderfly opened this issue Jan 9, 2015 · 10 comments
Closed

Add a static compile method to UriTemplate.java #42

wonderfly opened this issue Jan 9, 2015 · 10 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@wonderfly
Copy link
Contributor

From rmis...@google.com on October 14, 2011 09:59:45

Code review comment from Yaniv in http://codereview.appspot.com/5152047/ :

Design question: should we use a similar design pattern for UriTemplate as for regular expressions in Java, i.e. Pattern? The idea with Pattern is that you can pre-compile it and reuse to more efficiently match against multiple string inputs. The parallel here is that UriTemplates will typically be reused often on multiple parameter inputs. So it would be great to have a static compile(String template) method that returns a new compiled UriTemplate instance with an expand(Object parameters) method that performed the expansion. We could still keep the existing expand(String template, Object parameters) method, but its implementation would simply be UriTemplate.compile(template).expand(parameters).

But given that this design pattern is just a performance optimization and a significant re-work of your implementation, I'm happy to just leave it with a TODO and/or a feature request on the public Issue tracker to do in the future. It is relatively low priority.

Original issue: http://code.google.com/p/google-http-java-client/issues/detail?id=42

@wonderfly wonderfly added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. imported priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 9, 2015
@wonderfly wonderfly self-assigned this Jan 9, 2015
@wonderfly
Copy link
Contributor Author

From yan...@google.com on October 31, 2011 12:27:12

Status: Accepted

@wonderfly
Copy link
Contributor Author

From rmis...@google.com on November 17, 2011 07:35:33

Labels: -Milestone-Version1.7.0 Milestone-Version1.8.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on March 27, 2012 07:22:33

Labels: Milestone-Version1.9.0

@wonderfly
Copy link
Contributor Author

From rmis...@google.com on May 14, 2012 07:14:07

Labels: -Milestone-Version1.9.0 Milestone-Version1.10.0

@wonderfly
Copy link
Contributor Author

From rmis...@google.com on May 24, 2012 05:34:53

Labels: -Milestone-Version1.10.0 Milestone-Version1.11.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on August 02, 2012 05:12:55

Labels: -Priority-Low -Milestone-Version1.11.0 Priority-Medium

@wonderfly
Copy link
Contributor Author

From yan...@google.com on January 24, 2013 06:29:57

Consider doing this at same time as upgrading to latest specification.

Labels: Milestone-Version1.15.0 Component-HTTP

@wonderfly
Copy link
Contributor Author

From yan...@google.com on March 25, 2013 12:35:18

Owner: ngmic...@google.com
Labels: -Milestone-Version1.15.0 Milestone-Version1.16.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on June 10, 2013 06:07:42

Labels: -Milestone-Version1.16.0 Milestone-Version1.17.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on July 26, 2013 03:05:24

Labels: -Milestone-Version1.17.0

@wonderfly wonderfly removed their assignment May 20, 2016
@JustinBeckwith JustinBeckwith self-assigned this Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants